Project

General

Profile

Actions

Defect #33452

closed

Untranslated string "diff" in journal detail

Added by Go MAEDA almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
I18n
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The fix was submitted by Kam Nazir as part of Defect #31698. I have extracted this single fix from #31698 that contains multiple fixes because the hard-coded "diff" can be fixed without adding a new string to config/locales/*.yml files.

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 6b63f7e11..e18ff147a 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -553,7 +553,7 @@ module IssuesHelper
       unless no_html
         diff_link =
           link_to(
-            'diff',
+            l(:label_diff),
             diff_journal_url(detail.journal_id, :detail_id => detail.id,
                              :only_path => options[:only_path]),
             :title => l(:label_view_diff))


Files

diff-is-not-translated.png (24.1 KB) diff-is-not-translated.png Go MAEDA, 2020-05-16 01:54

Related issues

Related to Redmine - Defect #31698: Some unlocalize stringNew

Actions
Actions #1

Updated by Go MAEDA almost 4 years ago

Actions #2

Updated by Go MAEDA almost 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix contributed by Kam Nazir. Thank you.

Actions

Also available in: Atom PDF