Project

General

Profile

Actions

Defect #3405

closed

Calendar control missplacement with IE7

Added by Chris Martin almost 15 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
-
Start date:
2009-05-22
Due date:
% Done:

80%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Not sure if someone else already logged this. Searches didn't come up with anything. I'm using IE 7. When i click on the calendar popup
component in question
While the scroll bar is at the bottom of the screen, the calendar popup appears in the wrong spot. It's almost as if the placement does not account for vertical scrollbar shift.
how it looks


Files

img1.jpg (10.4 KB) img1.jpg component in question Chris Martin, 2009-05-22 00:11
img2.jpg (33.6 KB) img2.jpg how it looks Chris Martin, 2009-05-22 00:11
Actions #1

Updated by Jean-Philippe Lang almost 15 years ago

  • Subject changed from Calendar control missplacement to Calendar control missplacement with IE7
Actions #2

Updated by Chris Martin over 14 years ago

I've upgraded by browser to firefox, it's working fine there :D

Actions #3

Updated by Arnis Juraga over 14 years ago

  • % Done changed from 0 to 80

We have fixed it in local instance.
Modifyed file:

public\javascripts\calendar.js

Change in "function fixPosition(box)":
Replace:

br.y += document.body.scrollTop;
br.x += document.body.scrollLeft;

with:

scrollTop = (document.documentElement.scrollTop ? document.documentElement.scrollTop : document.body.scrollTop);
scrollLeft = (document.documentElement.scrollLeft ? document.documentElement.scrollLeft : document.body.scrollLeft);

br.y += scrollTop;
br.x += scrollLeft;

Can someone upload this change?

Actions #4

Updated by Jean-Philippe Lang over 14 years ago

  • Category changed from Issues to UI
Actions #5

Updated by Daniel Felix about 11 years ago

  • Status changed from New to Needs feedback

This works fine for me in Redmine 2.2.1 with IE9, FF 17 and Chrome 23.

I think this is resolved due to some jQuery UI changes. This Bug seems to be resolved. Anyone can test this with older browser versions?

Actions #6

Updated by Arnis Juraga about 11 years ago

Looks fixed. I have not noticed problem on latest Redmine versions anymore.

Actions #7

Updated by Chris Martin about 11 years ago

I'll see if i can test this out tomorrow and see how it behaves in IE 7

Actions #8

Updated by Daniel Felix about 11 years ago

Chris Martin wrote:

I'll see if i can test this out tomorrow and see how it behaves in IE 7

This would be great. I currently haven't any IE 7 to test this.

Actions #9

Updated by Chris Martin about 11 years ago

Tested with 2.1.2 and it's working great.

Actions #10

Updated by Daniel Felix about 11 years ago

  • Status changed from Needs feedback to Closed
  • Resolution set to Fixed

Great. Thanks for your test Chris!

This should be fixed.

Actions

Also available in: Atom PDF