Patch #34150
Use match? instead of =~ when MatchData is not used
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Performance | |||
Target version: | 4.2.0 |
Description
String#match?
was added in Ruby 2.4. you can replace =~
with faster String#match?
or Regexp#match?
when MatchData generated by `=~` is not necessary.
The attached patch changes such =~
to mach?
. I generated the patch with the following commands.
sed -i '' 's/TargetRubyVersion: 2.3/TargetRubyVersion: 2.4/' .rubocop.yml bundle exec rubocop --only Performance/RegexpMatch -a
Related issues
Associated revisions
Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA.
History
#1
Updated by Go MAEDA 4 months ago
- Blocks Patch #32530: Update RuboCop to 1.10 added
#2
Updated by Go MAEDA 4 months ago
- Related to Feature #34142: Drop Ruby 2.3 support added