Project

General

Profile

Actions

Patch #36770

closed

Fix to use a correct exception class ActiveRecord::IrreversibleMigration in migrations

Added by Go MAEDA over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When I tried to perform a reverse migration of db/migrate/20090503121510_drop_members_role_id.rb, I came across the following "uninitialized constant" error.

== 20090503121510 DropMembersRoleId: reverting ================================
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

uninitialized constant DropMembersRoleId::IrreversibleMigration

    raise IrreversibleMigration
          ^^^^^^^^^^^^^^^^^^^^^
/path/to/redmine/db/migrate/20090503121510_drop_members_role_id.rb:7:in `down'

It is due to an incorrect exception class given to raise method. The exception class should be ActiveRecord::IrreversibleMigration instead of IrreversibleMigration. I am attaching a patch to fix it. You will get the following error after the fix.

== 20090503121510 DropMembersRoleId: reverting ================================
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

ActiveRecord::IrreversibleMigration
/path/to/redmine/db/migrate/20090503121510_drop_members_role_id.rb:7:in `down'

Files

Actions #1

Updated by Go MAEDA over 2 years ago

  • Subject changed from Fix exception class from IrreversibleMigration to ActiveRecord::IrreversibleMigration to Fix to use a correct exception class ActiveRecord::IrreversibleMigration in migrations
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version set to 5.0.0

Committed the fix.

Actions

Also available in: Atom PDF