Project

General

Profile

Actions

Patch #38496

closed

Add missing fixtures to SearchControllerTest

Added by Go MAEDA 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Tests in search_controller_test.rb may fail due to missing fixtures.

$ bin/rake db:reset RAILS_ENV=test
$ ruby test/functional/search_controller_test.rb
Run options: --seed 26553

# Running:

.......F

Failure:
SearchControllerTest#test_results_should_be_escaped_once [test/functional/search_controller_test.rb:426]:
Expected false to be truthy.

rails test test/functional/search_controller_test.rb:425

..........F

Failure:
SearchControllerTest#test_keywords_should_be_highlighted [test/functional/search_controller_test.rb:436]:
Expected false to be truthy.

rails test test/functional/search_controller_test.rb:435

.......F

Failure:
SearchControllerTest#test_search_my_bookmarks [test/functional/search_controller_test.rb:179]:
Expected exactly 1 element matching "dt.issue", found 0..
Expected: 1
  Actual: 0

rails test test/functional/search_controller_test.rb:174

.........

Files

Actions #1

Updated by Go MAEDA 11 months ago

  • Subject changed from Add missing fixtures in search_controller_test.rb to Add missing fixtures to SearchControllerTest
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r22211.

Actions

Also available in: Atom PDF