Project

General

Profile

Actions

Defect #38617

closed

Redmine 4.2 on Ruby 2.4 is not compatible with loofah 2.21 or higher

Added by Anton Nekrasov 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Ruby support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Redmine 4.2 does not support ruby 2.4 after updated loofah gem to 2.21.1 version.
Loofah above 2.21.1 requires ruby >= 2.5

Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    actionpack-xml_parser was resolved to 2.0.1, which depends on
      actionpack (>= 5.0) was resolved to 6.1.7, which depends on
        Ruby (>= 2.5.0)

  Current Ruby version:
    Ruby (= 2.4.10)

Actions #1

Updated by Anton Nekrasov 10 months ago

Actions #2

Updated by Go MAEDA 10 months ago

  • Status changed from New to Confirmed
  • Target version set to 4.2.11

Setting the target version to 4.2.11

Index: Gemfile
===================================================================
--- Gemfile    (revision 22232)
+++ Gemfile    (working copy)
@@ -26,6 +26,7 @@
 gem 'addressable'
 gem 'rubyzip', '~> 2.3.0'
 gem 'psych', '~> 3.1' if Gem.ruby_version < Gem::Version.new('2.6.0')
+gem 'loofah', '<= 2.21.1' if Gem.ruby_version < Gem::Version.new('2.5.0')

 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
 gem 'tzinfo-data', platforms: [:mingw, :x64_mingw, :mswin]
Actions #3

Updated by Anton Nekrasov 10 months ago

I was wrong in the gem version. The problem seems to have happened before. Required loofah <= 2.20.0
Could you edit the Gemfile please

+gem 'loofah', '<= 2.20.0' if Gem.ruby_version < Gem::Version.new('2.5.0')
Actions #4

Updated by Go MAEDA 9 months ago

  • Subject changed from Redmine 4.2 not support ruby 2.4 after update loofah 2.21.1 gem to Redmine 4.2 on Ruby 2.4 is not compatible with loofah 2.21 or higher
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you for your contribution.

Actions #5

Updated by Anton Nekrasov 9 months ago

Thank you.

Actions

Also available in: Atom PDF