Project

General

Profile

Actions
Copy link

Patch #40513

closed

Fix initial_page_content method to avoid referencing @page instance variable in wiki formatting helpers

Added by Takuya Kodama 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
6.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The initial_page_content method in helpers mistakenly used the @page instance variable rather than the page argument provided to it. Since the use of @page is unnecessary and not expected, we've updated the method to correctly utilize the page argument.

Files

use-page-argument-in-initial-content.patch (1.81 KB) use-page-argument-in-initial-content.patch Takuya Kodama, 2024-04-02 09:34
Actions
Copy link
 #1

Updated by Go MAEDA 8 months ago

  • Target version set to 6.0.0
Actions
Copy link
 #2

Updated by Takuya Kodama 8 months ago

Thanks for your handling it:)

Actions
Copy link
 #3

Updated by Go MAEDA 8 months ago

  • Subject changed from Refactor initial_page_content to directly use page parameter to Fix initial_page_content method to avoid referencing @page instance variable in wiki formatting helpers
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r22781. Thank you.

Actions
Copy link

Also available in: Atom PDF