Project

General

Profile

Actions

Patch #41142

closed

Add missing assertion in Redmine::MenuManager::MapperTest#test_push_onto_root

Added by Go MAEDA about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The following patch addresses an issue in the Redmine::MenuManager::MapperTest#test_push_onto_root test where an assertion was missing.
The original test method was calling menu_mapper.exists?(:test_overview) but was not asserting the result, making the test ineffective.

diff --git a/test/unit/lib/redmine/menu_manager/mapper_test.rb b/test/unit/lib/redmine/menu_manager/mapper_test.rb
index 668c6b11b..c552db0fa 100644
--- a/test/unit/lib/redmine/menu_manager/mapper_test.rb
+++ b/test/unit/lib/redmine/menu_manager/mapper_test.rb
@@ -37,7 +37,7 @@ class Redmine::MenuManager::MapperTest < ActiveSupport::TestCase
     menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
     menu_mapper.push :test_overview, {:controller => 'projects', :action => 'show'}, {}

-    menu_mapper.exists?(:test_overview)
+    assert menu_mapper.exists?(:test_overview)
   end

   def test_push_onto_parent
Actions #1

Updated by Go MAEDA about 2 months ago

  • Subject changed from Add Missing Assertion in Redmine::MenuManager::MapperTest#test_push_onto_root to Add missing assertion in Redmine::MenuManager::MapperTest#test_push_onto_root
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version set to 6.0.0

Committed the fix in r22956.

Actions

Also available in: Atom PDF