Project

General

Profile

Actions

Defect #41263

closed

Gantt progress line misrendering for 0% progress issues/versions with future start dates beyond chart range

Added by Minoru Maeda 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Gantt
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

This patch (for trunk r23061) improves the precision of drawing the "Progress line" on the Gantt chart by considering the progress rate when an issue and its target version are ahead of schedule.

If the progress rate is 0, it is not considered ahead of schedule. Therefore, this patch changes the CSS class name from the traditional "over-end-date" to "ahead-start-date" and adjusts the drawing of the "Progress line" accordingly.

Before applying the patch
After applying the patch

Files

enhance-progress-line_trunk@23061.patch (2.15 KB) enhance-progress-line_trunk@23061.patch Minoru Maeda, 2024-09-18 10:30
before.png (77.2 KB) before.png Minoru Maeda, 2024-09-18 10:30
after.png (77.4 KB) after.png Minoru Maeda, 2024-09-18 10:30
clipboard-202409201157-8tjqt.png (94.8 KB) clipboard-202409201157-8tjqt.png Go MAEDA, 2024-09-20 04:57
clipboard-202409201201-mpg6w.png (112 KB) clipboard-202409201201-mpg6w.png Go MAEDA, 2024-09-20 05:01
clipboard-202409201203-rorb3.png (107 KB) clipboard-202409201203-rorb3.png Go MAEDA, 2024-09-20 05:03
41263-v2.patch (1.29 KB) 41263-v2.patch Go MAEDA, 2024-09-20 05:24
Actions #1

Updated by Go MAEDA 3 months ago

The suggested patch resolves an issue where the progress line display is distorted when an issue with 0% progress and a start date in the future, outside the displayed range of the Gantt chart, exists.

In the rendering of the progress line, an issue with 0% progress (which means unstarted) and a start date in the future should appear as if it is progressing according to schedule. In the screenshot below, issue #35 is displayed in this manner.

However, currently, even if an issue has 0% progress and a start date in the future, if the start date is beyond the displayed range of the Gantt chart, the progress line is incorrectly rendered as if it is progressing ahead of schedule, despite having 0% progress (as seen with issue #36 in the screenshot below).

The attached patch resolves this issue.

Actions #2

Updated by Go MAEDA 3 months ago

I think it is better not to change the CSS class name over-end-date because changing the class name may affect plugins or users' customizations that rely on it.

I have updated the patch accordingly.

Actions #3

Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next minor release to 5.0.10

Setting the target version to 5.0.10.

Actions #4

Updated by Go MAEDA 3 months ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r23068. Thank you for your contribution.

Actions #5

Updated by Go MAEDA 3 months ago

  • Status changed from Resolved to Closed

Merged the change to stable branches.

Actions

Also available in: Atom PDF