Project

General

Profile

Actions
Copy link

Patch #41313

closed

Fix test/unit/issue_test.rb to use correct IANA timezone name "Asia/Hong_Kong" instead of deprecated "Hongkong"

Added by Soren Stoutner about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
5.0.10
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I am working on updating the Debian package of Redmine. As part of that work, I noticed that test/unit/issue_test.rb produces the following failure:

Failure:
IssueTest#test_issue_overdue_should_respect_user_timezone [/<<PKGBUILDDIR>>/test/unit/issue_test.rb:3410]:
Expected false to be truthy.

rails test test/unit/issue_test.rb:3388

The root of this problem is that this test uses the Hongkong, which Debian no longer resolves to Asia/Hong_Kong. The attached patch fixes this problem by using Asia/Hong_Kong directly.

Files

0001-Correct-test-timezone-formatting.patch (800 Bytes) 0001-Correct-test-timezone-formatting.patch Soren Stoutner, 2024-09-24 22:54
Actions
Copy link
 #1

Updated by Go MAEDA about 1 month ago

  • Category set to Code cleanup/refactoring
  • Target version set to 6.0.0
Actions
Copy link
 #2

Updated by Go MAEDA about 1 month ago

  • Subject changed from test/unit/issue_test.rb uses outdated timezone format to Fix test/unit/issue_test.rb to use correct IANA timezone name "Asia/Hong_Kong" instead of deprecated "Hongkong"
  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Target version changed from 6.0.0 to 5.0.10

Committed the patch in r23079. Thank you.

Actions
Copy link
 #3

Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed

Merged the change to stable branches in r23080 and r23081.

Actions
Copy link

Also available in: Atom PDF