Project

General

Profile

Actions
Copy link

Patch #41914

closed

Fix random test failure in UserTest#test_validate_password_complexity due to missing explicit language setting

Added by Go MAEDA 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
6.0.2
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Failure:
UserTest#test_validate_password_complexity [test/unit/user_test.rb:580]:
Expected false to be truthy.

bin/rails test test/unit/user_test.rb:566
Actions
Copy link
 #1

Updated by Go MAEDA 3 months ago

To address the occasional test failures, I replaced assert with assert_includes in r23343.
assert_includes provides more informative error messages, making it easier to debug and resolve this issue.

Actions
Copy link
 #2

Updated by Go MAEDA 3 months ago

  • Subject changed from Fix randomtest failure in UserTest#test_validate_password_complexity to Fix random test failure in UserTest#test_validate_password_complexity
Actions
Copy link
 #3

Updated by Go MAEDA 3 months ago

We have to set the current user's language to English in the test.

Failure:
UserTest#test_validate_password_complexity [test/unit/user_test.rb:580]:
Expected ["Mot de passe est trop court (au moins 8 caractères)", "Mot de passe is too simple"] to include "Password is too simple".

bin/rails test test/unit/user_test.rb:566
Actions
Copy link
 #4

Updated by Go MAEDA 3 months ago

  • Subject changed from Fix random test failure in UserTest#test_validate_password_complexity to Fix random test failure in UserTest#test_validate_password_complexity due to missing explicit language setting
  • Status changed from New to Resolved
  • Target version changed from 6.1.0 to 6.0.2

Committed the fix for this issue in r23345.

Actions
Copy link
 #5

Updated by Go MAEDA 3 months ago

  • Status changed from Resolved to Closed

Merged the changes into the 6.0-stable branch in r23346.

Actions
Copy link

Also available in: Atom PDF