Project

General

Profile

Actions

Feature #42073

closed

Remove navigation parameters from issue detail URLs after updates

Added by Katsuya HIDAKA 10 days ago. Updated 8 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

This patch removes navigation parameters from the issue detail URL after updating an issue.

Before applying the patch:

http://localhost:3000/issues/2?issue_count=8&issue_position=2&next_issue_id=3&prev_issue_id=1

After applying the patch:

http://localhost:3000/issues/2

Background/Purpose

Currently, the URL of the issue detail screen after updating an issue includes navigation parameters like:

http://localhost:3000/issues/2?issue_count=8&issue_position=2&next_issue_id=3&prev_issue_id=1

These navigation parameters are used to display navigation in the issue detail screen:

  • prev_issue_id: The issue linked to the "Previous" button
  • next_issue_id: The issue linked to the "Next" button
  • issue_position, issue_count: Position information (e.g., "7 of 8")

The navigation is normally displayed based on the active filter and sort conditions. However, if the URL with navigation parameters is used, it is always displayed based on the parameter values, regardless of the current filter or sort settings.

For example, sharing the URL may cause incorrect navigation to appear for others. I think the URL should not be shareable.

Solution

This patch uses Flash to pass navigation information (e.g., next_issue_id, prev_issue_id) after updating an issue, removing the need to include navigation parameters in the URL. This ensures that a clean, shareable URL (e.g., http://example.net/issues/123) is maintained.

Additionally, users no longer need to manually remove unnecessary parameters when copying the URL from the browser’s address bar.

I confirmed all tests passed after applying the patch.
https://github.com/hidakatsuya/redmine/actions/runs/12620683503


Files

Actions #1

Updated by Go MAEDA 9 days ago

  • Target version set to Candidate for next major release
Actions #2

Updated by Go MAEDA 9 days ago

  • Target version changed from Candidate for next major release to 6.1.0

The changes look good to me. I have confirmed that the functionality works as expected. The improvement of removing unnecessary parameters from the issue URL is valuable.

I am setting the target version to 6.1.0.

Actions #3

Updated by Go MAEDA 8 days ago

  • Tracker changed from Patch to Feature
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch in r23433. Thank you for your contribution.

Actions

Also available in: Atom PDF