Project

General

Profile

Actions
Copy link

Defect #4718

closed

MenuManager dies if you delete all items and then re-add

Added by Robert Chady almost 15 years ago. Updated almost 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Davis
Category:
Plugin API
Target version:
0.9.3
Start date:
2010-02-02
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:
0.9.2

Description

If you delete all items for :top_menu and try to push new ones back, it errors out. An easy workaround is to delete one and push its replacement. The error output is attached.

Files

redmine_menumanager_error.txt (2.79 KB) redmine_menumanager_error.txt Robert Chady, 2010-02-02 20:52
Actions
Copy link
 #1

Updated by Eric Davis almost 15 years ago

  • Status changed from New to 7

Robert brought this to my attention on IRC. A workaround is to make sure a menu always has at least one item in it.

Actions
Copy link
 #2

Updated by Eric Davis almost 15 years ago

  • Status changed from 7 to Resolved
  • Target version set to 0.9.3
  • % Done changed from 0 to 100
  • Affected version (unused) set to 0.9.2
  • Resolution set to Fixed
  • Affected version set to 0.9.2

It turned out that the counters used to keep track of the :last menu items weren't decremented when an item was removed. This caused the menu to try to position the new menu item at a negative position.

Thanks for the bug report, I'm happy this was found. Fixed in r3447.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 15 years ago

  • Status changed from Resolved to Closed

Merged in 0.9-stable in r3461.

Actions
Copy link

Also available in: Atom PDF