Redmine

As per the FAQ, I modified my config/environments/production.rb settings so that mailer activities would be logged. As you can see, this confirms the issue of no recipient addresses being used:

Processing ProjectsController#add_file (for xxx.xxx.xxx.xxx at 2010-02-24 15:50:08) [POST]
  Parameters: {"commit"=>"Add", "action"=>"add_file", "authenticity_token"=>"PhQkKzGZ2diEjdIdjsZHPootAQpWWElnx4LkI22/I=", "id"=>"projectid", "controller"=>"projects", "attachments"=>{"1"=>{"file"=>#<File:/tmp/RackMultipart20100224-84201-1ashycm-0>, "description"=>"test"}}}
Sent mail to 
Redirected to http://*******.co.uk/projects/projectid/files
Completed in 508ms (DB: 3) | 302 Found [http://*******.co.uk/projects/projectid/files/new]

Further to the details above ... My original installation of Redmine was on OSX. That copy is still installed, and still broken.

Since then I created a Fedora VM to test it out there, installed Redmine, and everything is working as expected.

Both installations are approximately identical, bar a few vendor packaging differences.
Both use Apache, Passenger, MySQL, and rails versions. Also, they're both configured with the same email account/server for sending mail.

There is one difference ... Fedora has Ruby 1.8.6, and OSX has Ruby 1.8.7.
I find it hard to believe that is the problem though.

Emails without recipients should not be sent.
A test was added for that in r3518 and it passes with ruby 1.8.7.

I have retested on OSX, with another user added to the project. Again, when a file is uploaded an email is generated with no recipients.
The problem isn't that an email isn't being sent, but that an email is being sent without recipients.

Identical tests on my Fedora installation work perfectly, only my OSX installation is affected.

I have re-installed my OSX redmine from scratch, to be sure I haven't messed up the install, and the problem still occurs.

I just want to add some details:
if submit any changes to the issues, we can see in production.log the message like this:

Sending email notification to: name1.surname1@email.domain.com, name2.surname2@email.domain.com, name3.surname3@email.domain.com

but if we add a new document or upload a file, we can see another recipients list:

Sending email notification to: Name1 Surname1, Name2 Surname2, Name3 Surname3

and the notification is not received in the last case.
the logic for recipients has been updated in app/modules/mailer.rb for 9.2 version, and it seems not accurately well.

I've changed app/models/mailer.rb a little and now all notifications are sent to their recipients

Index: app/models/mailer.rb
===================================================================
--- app/models/mailer.rb        (revision 3521)
+++ app/models/mailer.rb        (working copy)
@@ -114,11 +114,11 @@
     when 'Project'
       added_to_url = url_for(:controller => 'projects', :action => 'list_files', :id => container)
       added_to = "#{l(:label_project)}: #{container}" 
-      recipients container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}
+      recipients container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}.collect  {|m| m.mail}
     when 'Version'
       added_to_url = url_for(:controller => 'projects', :action => 'list_files', :id => container.project_id)
       added_to = "#{l(:label_version)}: #{container.name}" 
-      recipients container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}
+      recipients container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}.collect {|m| m.mail}
     when 'Document'
       added_to_url = url_for(:controller => 'documents', :action => 'show', :id => container.id)
       added_to = "#{l(:label_document)}: #{container.title}"