Redmine

Please see http://www.redmine.org/issues/4773#note-14 and try patch of #4773.

Toshi Maruyama wrote:

Please see http://www.redmine.org/issues/4773#note-14 and try patch of #4773.

Patches didn't help.. (First patch was already in release, second - didn't help).
It seems that code hungs at call to shellout function:
Mongrel::TimeoutError (Mongrel timed out this thread: shutdown):
lib/redmine/scm/adapters/abstract_adapter.rb:191:in `shellout'
lib/redmine/scm/adapters/abstract_adapter.rb:177:in `shellout'
lib/redmine/scm/adapters/git_adapter.rb:92:in `lastrev'
lib/redmine/scm/adapters/git_adapter.rb:78
lib/redmine/scm/adapters/git_adapter.rb:66:in `each_line'
lib/redmine/scm/adapters/git_adapter.rb:66
lib/redmine/scm/adapters/abstract_adapter.rb:193:in `call'
lib/redmine/scm/adapters/abstract_adapter.rb:193:in `shellout'
lib/redmine/scm/adapters/abstract_adapter.rb:191:in `popen'
lib/redmine/scm/adapters/abstract_adapter.rb:191:in `shellout'
lib/redmine/scm/adapters/abstract_adapter.rb:177:in `shellout'
lib/redmine/scm/adapters/git_adapter.rb:65:in `entries'
app/models/repository.rb:63:in `entries'
app/controllers/repositories_controller.rb:72:in `show'

Vladimir Babchuk wrote:

Patches didn't help.. (First patch was already in release, second - didn't help).

Sorry, patch is http://www.redmine.org/attachments/3272/git-fast-browse.patch .

Toshi Maruyama wrote:

Vladimir Babchuk wrote:

Patches didn't help.. (First patch was already in release, second - didn't help).

Sorry, patch is http://www.redmine.org/attachments/3272/git-fast-browse.patch .

Thanks! That patch helped me.
But... it like a hack (now I can't see revision, comment and etc. in repo browser). So problem is still remained.
Any thoughts how to fix it right? I can tree it in free time, but i can't realize what is causes it.
If execute commands that executes shellout by hand - git exits instantly.
By default git uses less to page results, but I disabled it. What else can cause thread lockup?

Vladimir Babchuk wrote:

Thanks! That patch helped me.
But... it like a hack (now I can't see revision, comment and etc. in repo browser). So problem is still remained.
Any thoughts how to fix it right? I can tree it in free time, but i can't realize what is causes it.
If execute commands that executes shellout by hand - git exits instantly.
By default git uses less to page results, but I disabled it. What else can cause thread lockup?

http://www.redmine.org/issues/4773#note-12

Actually, what is really slow when browsing a git repository is to get information about last change on each file using git log -n 1. When removing this, browsing is pretty fast. Maybe we should disable this.

Toshi Maruyama wrote:

Actually, what is really slow when browsing a git repository is to get information about last change on each file using git log -n 1. When removing this, browsing is pretty fast. Maybe we should disable this.

Yes, I see. But in my repository only near ~15 files and ~10 commits. It can't be parsed so long! I think - there are other cause of this problem.

I'm having the same performance problems related to git repositories. First the obligatory ENV schtuff:

• Redmine 0.9.2.devel.3437 (MySQL)
• ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux]
• Rails 2.3.5
• mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (x86_64) using readline 5.2

Info about repo:

• git version 1.5.6.5
• 400 commits
• < 5,000 files

Troubling for me is how redmine completely blocks until this view is rendered, and we're talking several minutes.

Mitch Pirtle wrote:

• Redmine 0.9.2.devel.3437 (MySQL)

Which has known performance issue with git, I don't they have been backported to 0.9.x, but definitely are in 1.0.x and trunk.

Troubling for me is how redmine completely blocks until this view is rendered, and we're talking several minutes.

What rails server do you use? If it's a single webrick or mongrel, that happens because multi-threading/multiple incoming connections are handled by spinning up more instances, which neither of both does on itself.

Thanks for the explanation Felix.

This is a dev server running lighttpd, which probably explains the blocking.

Will update to trunk when I get the chance, as we could really use some relief.

Redmine git adapter use "io.gets" at source:tags/1.0.3/lib/redmine/scm/adapters/git_adapter.rb#L94 .
It seems there is same problem with #6860.
It maybe we should use "io.each_line" instead of "io.gets".