Defect #5199
diff code coloring using coderay
| Status: | Closed | Start date: | 2010-03-28 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Time tracking | |||
| Target version: | 1.0.0 (RC) | |||
| Resolution: | Fixed | Affected version: | 0.9.3 |
Description
This seems not to work when I do pre and code style=diff. CodeRay however can highlight diffs.
As an example:
--- 2010-03-28.gp_invprint 2010-03-28 03:21:46.000000000 +0300
+++ gp_invprint 2010-03-28 03:23:08.000000000 +0300
@@ -535,7 +535,9 @@
$p->text({align=> 'centre'}, 300, 120, "TAX INVOICE");
$p->setfont("Arial", "8");
- $p->text({align=> 'right'}, 580, 120, "TIN:nnnn VAT: mmm");
+ # old style tin. changed due to request.
+ #$p->text({align=> 'right'}, 580, 120, "TIN:nnnn VAT: mmm");
+ $p->text({align=> 'right'}, 580, 120, "e-TIN xxx VAT: rrr");
$p->setfont($font{"name"}, 10);
$p->text({align=> 'right'}, 100, 190, "Name: ");
Associated revisions
Fixes diff highlighting (#5199).
History
#1
Updated by Jean-Philippe Lang about 10 years ago
- Category set to Time tracking
- Status changed from New to Closed
- Target version set to 1.0.0 (RC)
- Resolution set to Fixed
This is fixed in r3619.
Note that you have to use class="diff" instead of style="diff". Your example was fixed.
#2
Updated by Holger Just about 10 years ago
- Status changed from Closed to Reopened
The fix in r3619 breaks the test suite. Specifically test_syntax_highlight(ApplicationHelperTest)
#3
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from Reopened to Closed
Test fixed in r3622.
#4
Updated by Kornelius Kalnbach about 10 years ago
It doesn't look like it's supposed to look. :wrap => :span is not the right way to go, as it doesn't support the new line tokens that diff code needs.
I recommend using .div instead of .html.