Project

General

Profile

Actions

Defect #5297

closed

openid not validated correctly

Added by Niklas ... over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Low
Category:
Accounts / authentication
Target version:
Start date:
2010-04-12
Due date:
% Done:

100%

Estimated time:
0.50 h
Resolution:
Fixed
Affected version:

Description

the user supplied a openid with a semicolon instead of the colon. instead of a validation / login error he got a 500. trace is:

NoMethodError (undefined method `downcase' for nil:NilClass):
  app/controllers/account_controller.rb:153:in `open_id_authenticate'
  app/controllers/account_controller.rb:33:in `login'
  passenger (2.2.4) lib/phusion_passenger/rack/request_handler.rb:91:in `process_request'
  passenger (2.2.4) lib/phusion_passenger/abstract_request_handler.rb:206:in `main_loop'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:376:in `start_request_handler'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:181:in `spawn_application!'
  passenger (2.2.4) lib/phusion_passenger/utils.rb:182:in `safe_fork'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:153:in `spawn_application!'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:271:in `spawn_rails_application'
  passenger (2.2.4) lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
  passenger (2.2.4) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:254:in `spawn_rails_application'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:153:in `spawn_application'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:286:in `handle_spawn_application'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:351:in `__send__'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:351:in `main_loop'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:195:in `start_synchronously'
Actions

Also available in: Atom PDF