Redmine

(snip)

Guys, please apply this patch! :(

Can you just give us some details about your use case ? As said in other issues, we could add hooks everywhere but it will become hard to maintain. Can't you use rails standard callbacks ? Just tell us a bit more.

There is an external tool which receives notifications from Redmine about new issues, changes in issues... new time entries, changes in time entries etc. I wrote a very little Redmine plugin responsible for sending notification to this tool.

If I "attach" to standard Rails callbacks the external tool fails to find a corresponding record in database because they do not exist yet at the moment of notification. So I found that using hooks works very well - records are always there already.

Andriy Lesyuk wrote:

If I "attach" to standard Rails callbacks the external tool fails to find a corresponding record in database because they do not exist yet at the moment of notification.

Even with an after_save callback on the right object ? (Issue or TimeEntry I presume)

Yes. I googled a little for this issue and that's what I've found:

For example, if you invoke an external indexer at this point it won‘t see the changes in the database.

http://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html#M001373

Not sure if this is what you requested:

class IssueHook  < Redmine::Hook::ViewListener

    def controller_issues_new_after_save(context = {})
        if context[:issue] && context[:issue].id.present?
            Monkey.instance.tell("+issue:#{context[:issue].id}/cinas")
        end
    end

    def controller_issues_edit_after_save(context = {})
        if context[:time_entry] && context[:time_entry].id.present?
            Monkey.instance.tell("+entry:#{context[:time_entry].id}/cieas")
        end
        if context[:journal] && context[:journal].id.present?
            Monkey.instance.tell("+journal:#{context[:journal].id}/cieas")
        end
    end

    def controller_issues_bulk_edit_after_save(context = { })
        if context[:journal] && context[:journal].id.present?
            Monkey.instance.tell("+journal:#{context[:journal].id}/cibeas")
        end
    end

    def controller_journals_edit_post(context = { })
        if context[:journal] && context[:journal].id.present? && context[:journal].notes.present?
            Monkey.instance.tell("=journal:#{context[:journal].id}/cjep")
        end
    end

    def controller_timelog_edit_after_save(context = { })
        if context[:time_entry] && context[:time_entry].id.present?
            if context[:params][:id].present?
                Monkey.instance.tell("=entry:#{context[:time_entry].id}/cteas")
            else
                Monkey.instance.tell("+entry:#{context[:time_entry].id}/cteas")
            end
        end
    end

    def controller_bulk_time_entries_new_after_save(context = { })
        if context[:time_entry] && context[:time_entry].id.present?
            Monkey.instance.tell("+entry:#{context[:time_entry].id}/cbtenas")
        end
    end

end

If not - tell me what do you need and I will post.

Andriy Lesyuk wrote:

Not sure if this is what you requested:

From what I see, you can use observers for Issue, TimeEntry, and Journal using the after_save callback provided by Rails. after_save is fired after the record is created so you should be able to access the id.

Eric Davis wrote:

Andriy Lesyuk wrote:

Not sure if this is what you requested:

From what I see, you can use observers for Issue, TimeEntry, and Journal using the after_save callback provided by Rails. after_save is fired after the record is created so you should be able to access the id.

This id is sent to the external tool written in Perl. This Perl tool then fetches corresponding records from database. If I use Rails callbacks the tool fails to find the records. So, no, I can't use standard Rails callbacks.

Well... I'm not sure that waiting for commit is the best solution in this case. For now I choose patching the code. :) Perhaps in future will try to find some solution not requiring patching.

I checked a little the latest code of IssuesController and found that it still contains hooks. I'm not sure why don't you want to include other hooks like ones suggested by me... It seems that you are just renaming hooks. As soon as you provide a similar after_save hook for timelog I will be happy. :) I don't want you to apply my patch I just want you to provide an after_save hook...

Thanks

Closing this, status is resolved since 400 days and more (issue was last updated more than 400 days ago)...