Project

General

Profile

Actions

Defect #5983

open

Redmine.pm possible wrong HTTP responce

Added by Georgi Markov over 13 years ago. Updated about 13 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
SCM extra
Target version:
-
Start date:
2010-07-28
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

The Redmine of mine;) is r3832. SVN (WebDAV) user authentication via Redmine.pm in mixed user authentication mode - MySQL for some & LDAP for others.
When a user authenticates himself for a commit and has no (Redmine) right to do that, the HTTP response is 401 (auth_required). It's somehow confusing as the user may think she simply mistyped her password. We use TortoiseSVN and the login window is just cleared. The problem was reproduced for both DB and LDAP authenticated users. I'm not a perl hacker, but simply swapping lines 202 & 226 in Redmine.pm did the trick for me:

  return FORBIDDEN;
...
  return AUTH_REQUIRED;

I certainly cannot be positive that it does not break something else..

Anyway: grat job guys!

Actions #1

Updated by Ве Fio over 13 years ago

Wow, that explains A LOT. This has happened to me MANY times, and it does appear you entered the wrong credentials, so you keep entering them and it's never accepted, it's pretty annoying. I also think that something weird happens if you try to do something like:

svn ls http://svn.domain.com/
Where svn.domain.com has a public root of /home/svn and projects are in subdirectories, e.g. /home/svn/project1
The same command,
svn ls http://svn.domain.com/project1
works fine for reading and committing, but not on the public root pointed at /home/svn

Actions #2

Updated by Toshi MARUYAMA about 13 years ago

  • Category set to SCM extra
Actions

Also available in: Atom PDF