Project

General

Profile

Actions
Copy link

Defect #5983

open

Redmine.pm possible wrong HTTP responce

Added by Georgi Markov over 14 years ago. Updated over 13 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
SCM extra
Target version:
-
Start date:
2010-07-28
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

The Redmine of mine;) is r3832. SVN (WebDAV) user authentication via Redmine.pm in mixed user authentication mode - MySQL for some & LDAP for others.
When a user authenticates himself for a commit and has no (Redmine) right to do that, the HTTP response is 401 (auth_required). It's somehow confusing as the user may think she simply mistyped her password. We use TortoiseSVN and the login window is just cleared. The problem was reproduced for both DB and LDAP authenticated users. I'm not a perl hacker, but simply swapping lines 202 & 226 in Redmine.pm did the trick for me:

  return FORBIDDEN;
...
  return AUTH_REQUIRED;

I certainly cannot be positive that it does not break something else..

Anyway: grat job guys!

Actions
Copy link

Also available in: Atom PDF