Project

General

Profile

Actions

Defect #649

closed

Menu translations broken

Added by Michael Pirogov over 16 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
High
Category:
Translations
Target version:
-
Start date:
2008-02-13
Due date:
% Done:

100%

Estimated time:
Resolution:
Affected version:

Description

Menu translations broken in /lib/redmine.rb after r1137.

Missed :caption => in menu items.


Related issues

Related to Redmine - Patch #650: Menu translationClosedJean-Philippe Lang2008-02-13

Actions
Actions #1

Updated by Michael Pirogov over 16 years ago

Patch has been included in #650

Actions #2

Updated by Jean-Philippe Lang over 16 years ago

Some :caption options were intentionally removed in r1137, since menu names are now automatically mapped to the proper localized string if it exists (eg. if the menu name is :foo, the translated string :label_foo will be automatically used if it exists).

Look at the very end of this diff:
http://www.redmine.org/repositories/diff/redmine//trunk/lib/redmine/menu_manager.rb?rev=1137

It works fine for me. Could you confirm the bug ?

Actions #3

Updated by Michael Pirogov over 16 years ago

OK. Fresh checkout seems to be working. Fault is somewhere on my side. This issue have to be closed. Thanks and sorry for the havoc.

Actions #4

Updated by Jean-Philippe Lang over 16 years ago

  • Status changed from New to Closed
Actions #5

Updated by Michael Pirogov over 16 years ago

  • Status changed from Closed to Reopened

Got it :)

If I use any plugin, then all top menus translations are broken. Try to add extra/sample_plugin to the vendor/plugins/ directory, restart rails and you'll see. Probably it cause of that plugin uses its own ymls?

Actions #6

Updated by Jean-Philippe Lang over 16 years ago

  • Status changed from Reopened to Closed
  • % Done changed from 0 to 100

Applied in changeset r1172.

Actions

Also available in: Atom PDF