Actions
Defect #6839
closedHardcoded absolute links in my/page_layout
Start date:
2010-11-05
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Since this bug is independent from any other software versions, I am omitting the usual information.
There are absolute links hardcoded in redmine views, which does not work if redmine is hosted in some subdirectory (e.g. "/redmine").
This is the location I found so far, but I don't know if it's the only one.
In app/views/my/page_layout.rhtml:
Sortable.create("list-top", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('/my/order_blocks?group=top', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-top")})}, only:'mypage-box', tag:'div'}) Sortable.create("list-left", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('/my/order_blocks?group=left', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-left")})}, only:'mypage-box', tag:'div'}) Sortable.create("list-right", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('/my/order_blocks?group=right', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-right")})}, only:'mypage-box', tag:'div'})
They should be replaced by
Sortable.create("list-top", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('<%= url_for(:controller => 'my', :action => 'order_blocks', 'group' => 'top') %>', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-top")})}, only:'mypage-box', tag:'div'}) Sortable.create("list-left", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('<%= url_for(:controller => 'my', :action => 'order_blocks', 'group' => 'left') %>', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-left")})}, only:'mypage-box', tag:'div'}) Sortable.create("list-right", {constraint:false, containment:['list-top','list-left','list-right'], dropOnEmpty:true, handle:'handle', onUpdate:function(){new Ajax.Request('<%= url_for(:controller => 'my', :action => 'order_blocks', 'group' => 'right') %>', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("list-right")})}, only:'mypage-box', tag:'div'})
Updated by Jean-Philippe Lang almost 14 years ago
- Status changed from New to Resolved
- Target version set to 1.0.4
- Resolution set to Fixed
Fixed in r4380. Thanks.
Updated by Jean-Philippe Lang almost 14 years ago
- Subject changed from Hardcoded absolute links to Hardcoded absolute links in my/page_layout
Updated by Jean-Philippe Lang almost 14 years ago
- Category set to Code cleanup/refactoring
- Status changed from Resolved to Closed
Merged in 1.0-stable in r4400.
Actions