Project

General

Profile

Actions

Defect #7122

closed

Issue-description Quote-button missing

Added by Mischa The Evil over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Start date:
2010-12-17
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Due to the refactoring of the IssuesController, IssuesController#reply has been moved into JournalsController#new in r3941. During this specific refactoring one LOC has been forgotten to be changed according to the new controller-schema.
This fault causes that issue description's quote-button is not showing up in the UI.

I've been able to patch this defect using the following change (which I won't upload as a seperate patch-file due to its size :):

Index: app/views/issues/show.rhtml
===================================================================
--- app/views/issues/show.rhtml (revision 4515)
+++ app/views/issues/show.rhtml (working copy)
@@ -49,7 +49,7 @@
 <hr />
 <% if @issue.description? %>
        <div class="contextual">
-       <%= link_to_remote_if_authorized(l(:button_quote), { :url => {:action => 'reply', :id => @issue} }, :class => 'icon icon-comment') %>
+       <%= link_to_remote_if_authorized(l(:button_quote), { :url => {:controller => 'journals', :action => 'new', :id => @issue} }, :class => 'icon icon-comment') %>
        </div>

        <p><strong><%=l(:field_description)%></strong></p>

Since this (small) issue is affecting current stable branch (actually, it's introduced in Redmine 1.0.1) I've set the target version to 1.0.5. Please correct it if necessary...

Actions #1

Updated by Jean-Philippe Lang about 13 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Fixed in r4530 with a simple test and merged in 1.0-stable.
Thanks.

Actions

Also available in: Atom PDF