Project

General

Profile

Actions
Copy link

Defect #7176

closed

cvs diff is always empty

Added by Toshi MARUYAMA over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2010-12-27
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:
1.0.5

Description

I attach a patch cvs-diff.diff to fix this problem and images.

Before applying patch

After applying patch

Files

Download all files
before-patch.png (23.2 KB) before-patch.png Toshi MARUYAMA, 2010-12-27 06:05
after-patch.png (82.5 KB) after-patch.png Toshi MARUYAMA, 2010-12-27 06:05
cvs-diff.diff (1.53 KB) cvs-diff.diff Toshi MARUYAMA, 2010-12-27 06:05
Actions
Copy link
 #1

Updated by Jean-Philippe Lang over 13 years ago

Can you include in your patch a test that fails without the fix?

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 13 years ago

Sorry, an existing test was actually failing.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 13 years ago

  • Status changed from New to Resolved
  • Target version set to 29
  • Affected version (unused) changed from 1.0.4 to 1.0.5
  • Resolution set to Fixed
  • Affected version changed from 1.0.4 to 1.0.5

Fix applied in r4577, thanks.

Actions
Copy link
 #4

Updated by Etienne Massip over 13 years ago

This issue has been fixed with 1.1.0 !

Actions
Copy link
 #5

Updated by Jean-Baptiste Barth over 13 years ago

  • Status changed from Resolved to Closed
  • Target version deleted (29)

Thanks Etienne, I remove the target version so that we can close 1.0.6 version (so bad admins can't affect an issue to a closed version ;))

Actions
Copy link

Also available in: Atom PDF