Feature #7223

Make SCM Error logging compatible with TorqueBox

Added by Mike Battles over 11 years ago. Updated over 11 years ago.

Status:NewStart date:2011-01-03
Priority:LowDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-
Resolution:

Description

I am currently working on integrating Redmine into my client's environment using TorqueBox and was experiencing some difficulty integrating with SVN. Upon further inspection, I noticed that all the internal SCM commands were failing while the rake fetch_changeset command was successful.

Turns out that TorqueBox was prepending "vfs:/" to RAILS_ROOT. Since I was running in dev, it was redirecting the errors to '2>>#{RAILS_ROOT}/log/scm.stderr.log'. This didn't work and the shell execution failed. Since the SVN command didn't even execute the error handling never properly caught it and it died later with a NPE.

This was easy enough to work around but I think that the logger.debug statement should be moved to line 189 (after the error appending block). You may also want to consider additional error handling for other obscure failures which prevent the shell from properly executing.

History

#1 Updated by Mike Battles over 11 years ago

Forgot to mention I was referring to lib/redmine/scm/adapters/abstract_adapter.rb

#2 Updated by Jean-Philippe Lang over 11 years ago

  • Tracker changed from Defect to Feature
  • Subject changed from SCM Error logging incompatible with TorqueBox to Make SCM Error logging compatible with TorqueBox

Also available in: Atom PDF