Defect #7288
closedNon ASCII filename downloaded from repo is broken on Internet Explorer.
0%
Description
On Internet Explorer, a filename downloded from repository is broken, because that filename is consist of multibyte characters. But, that is absolutely normal on Chrome.
In addition, attached files in the Redmine "files" page have no problem.
I think that this code has no problem,
./controllers/attachments_controller.rb: send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
... and this code has a problem.
./controllers/repositories_controller.rb: send_data @content, :filename => @path.split('/').last
I test that modification like below, and it seems successful!
send_data @content, :filename => filename_for_content_disposition(@path.split('/').last)
In my opinion, some of other
send_datas can have similar problems.
Files
Updated by Kesarr B almost 14 years ago
Toshi MARUYAMA wrote:
What SCM do you use?
I use Subversion as SCM.
Updated by Toshi MARUYAMA almost 14 years ago
Subversion stored paths as Unicode.
Can you paste a path and attach a image?
Updated by Kesarr B almost 14 years ago
- File redmine_repository_download_original.png redmine_repository_download_original.png added
- File redmine_repository_download_modified.png redmine_repository_download_modified.png added
Toshi MARUYAMA wrote:
Subversion stored paths as Unicode.
Can you paste a path and attach a image?
Updated by Toshi MARUYAMA almost 14 years ago
- Subject changed from Non-ISO-8859-1 filename downloaded from repo is broken on Internet Explorer. to Non ASCII filename downloaded from repo is broken on Internet Explorer.
Thanks. Is it Korean named file?
Updated by Kesarr B almost 14 years ago
Toshi MARUYAMA wrote:
Thanks. Is it Korean named file?
Yes, it is. And both WRONG and RIGHT have the exactly same url.
Updated by Toshi MARUYAMA almost 14 years ago
- Target version set to 1.1.2
- Affected version (unused) set to 1.1.1
- Affected version set to 1.1.1
Updated by Toshi MARUYAMA almost 14 years ago
- File ie-before.png ie-before.png added
- File ie-after.png ie-after.png added
- Status changed from New to Closed
- Resolution set to Fixed
I commited trunk r4816 and 1.1 r4819.
These are images on my Japanese Windows Vista and IE 8.
"send_data" at source:trunk/app/controllers/repositories_controller.rb@4817#L164 is revision and it is ASCII.