Actions
Defect #7288
closedNon ASCII filename downloaded from repo is broken on Internet Explorer.
Start date:
2011-01-11
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
On Internet Explorer, a filename downloded from repository is broken, because that filename is consist of multibyte characters. But, that is absolutely normal on Chrome.
In addition, attached files in the Redmine "files" page have no problem.
I think that this code has no problem,
./controllers/attachments_controller.rb: send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
... and this code has a problem.
./controllers/repositories_controller.rb: send_data @content, :filename => @path.split('/').last
I test that modification like below, and it seems successful!
send_data @content, :filename => filename_for_content_disposition(@path.split('/').last)
In my opinion, some of other
send_datas can have similar problems.
Files
Updated by Toshi MARUYAMA over 14 years ago
- Subject changed from Non-ISO-8859-1 filename downloaded from repo is broken on Internet Explorer. to Non ASCII filename downloaded from repo is broken on Internet Explorer.
Updated by Toshi MARUYAMA about 14 years ago
- Target version set to 1.1.2
- Affected version (unused) set to 1.1.1
- Affected version set to 1.1.1
Updated by Toshi MARUYAMA about 14 years ago
- File ie-before.png ie-before.png added
- File ie-after.png ie-after.png added
- Status changed from New to Closed
- Resolution set to Fixed
Actions