Redmine

I have some questions.

• Is copyright correct?
  Please see note-204 of #4455.
• Is .gitignore correct?

And please see source:/trunk/lib/redmine/scm/adapters/mercurial/redminehelper.py@4833#L1

I wrote the gravatar management based on the theme management. So it is an derivative of Redmine itself, particulary lib/redmine/themes.rb and test/unit/lib/redmine/thmes_test.rb.
I believe the copyright is correct. It should inherit JPL's copyright entry. Do you mean I should have added my own copyright entry?

And I believe .gitignore is also correct. This is because an additional gravatar is not a part of redmine. It is correct unless Redmine itself will have its own additional gravatar.

The license looks good to me, since 1) Redmine project is globally copyrighted by Jean-Philippe, and 2) many files would need a license update anyway. But we could include copyright from other people too, depends on Jean-Philippe thoughts on this point.

The .gitignore looks correct too, but I'll put it in the main .gitignore file as not everybody is familiar with Git here, it will be easier to maintain.

Any other blocker to include this ?

any progress?

This feature doesn't seem to be needed by a lot of people, so if you don't mind, I'd prefer to commit the plugin based solution. Is it OK for you?