Project

General

Profile

Actions

Defect #7960

closed

Settings->email->notified_events bug

Added by Petr Pospisil over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
-
Category:
Administration
Target version:
-
Start date:
2011-03-22
Due date:
% Done:

100%

Estimated time:
1.00 h
Resolution:
Invalid
Affected version:

Description

Hi,

in SettingsController was changed row to "@notifiables = Redmine::Notifiable.all", but helper SettingsHelper (method setting_multiselect) doesn't reflect it. Please add "value = value.name if value.is_a?(Redmine::Notifiable)" between row #46 and #47.

        text, value = (choice.is_a?(Array) ? choice : [choice, choice]) 
        value = value.name if value.is_a?(Redmine::Notifiable)
        content_tag('label',
          check_box_tag("settings[#{setting}][]", value, Setting.send(setting).include?(value)) + text.to_s,
          :class => 'block'
        )

Without this patch checkboxes at view "settings/_notifications.rhtml" are never checked so emails are not send. Thank you for fix.

Petr

Actions #1

Updated by Etienne Massip over 13 years ago

Can't reproduce.

setting_multiselect is not used to render the checkboxes ?

Actions #2

Updated by Petr Pospisil over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Etienne Massip over 13 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Invalid

Did you find the source of your issue ?

Actions #4

Updated by Petr Pospisil over 13 years ago

oh yeah :-). I had a older version of settings/_notifications.rhtml. I am sorry for the confusion. Petr

Actions

Also available in: Atom PDF