Feature #8423

Redirect to self (action) in MyController

Added by Andriy Lesyuk over 10 years ago. Updated over 10 years ago.

Status:ReopenedStart date:2011-05-23
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:-
Resolution:Invalid

Description

Is there any reason for redirecting to :action => 'acount' (the same action) on successful save in MyController's account action?..

I'm adding fields to users form (including one in my contoller) from my plugin. Saving fields with after_filter... When format of fields is invalid due to redirect original form data get lost.

P.S. Do not want to alias account method to avoid conflicts...

History

#1 Updated by Etienne Massip over 10 years ago

  • Status changed from New to Closed

Redirection to :action => 'account' seems logical to me, what would you expect ?

Try using after_save filter in User instead of using a controller after_filter filter ?

#2 Updated by Etienne Massip over 10 years ago

  • Resolution set to Invalid

You should ask your question in Devlopment forum, this tracker is for bugs or feature requests only.

#3 Updated by Andriy Lesyuk over 10 years ago

Without redirect_to it would render account.rhtml that is actually do the same: I wonder why redirect_to... I expect just rendering account...

#4 Updated by Andriy Lesyuk over 10 years ago

  • Status changed from Closed to Reopened

Reopening for you to note my last comment...

#5 Updated by Etienne Massip over 10 years ago

  • Category set to Code cleanup/refactoring

Red it already ; I'm not sure this redirect is useful, indeed, but I think it's harmless and should not bother you ?

#6 Updated by Andriy Lesyuk over 10 years ago

It does not bother me much... :) But it "limits" me. I guess it could be a typo so that's why reported.

#7 Updated by Etienne Massip over 10 years ago

  • Tracker changed from Defect to Feature

Also available in: Atom PDF