Project

General

Profile

Actions
Copy link

Defect #8458

closed

Subversion: Delete invalid repository fails using the libsvn plugin

Added by André Jonsson over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
SCM
Target version:
-
Start date:
2011-05-29
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:
1.1.3

Description

Only tested with svn repositories, using the libsvn plugin.

When an unreachable repository has been entered it is impossible to delete it. Apparently it requires the repository be valid and able to connect to be deleted.

For example, entering the repos url svn://localhost will cause delete to fail with the attached log message 1.

And entering a correct repos url but with incorrect login info fails similarly, with attached log message 2.

Files

Download all files
logmessage1.txt (946 Bytes) logmessage1.txt log message 1 André Jonsson, 2011-05-29 12:50
logmessage2.txt (991 Bytes) logmessage2.txt log message 2 André Jonsson, 2011-05-29 12:50
git-scm-nil.diff (873 Bytes) git-scm-nil.diff Toshi MARUYAMA, 2011-05-30 02:43

Related issues

Related to Redmine - Defect #6713: Git: Not able to Resetting Redmine project respositoryNewToshi MARUYAMA2010-10-20

Actions
Related to Redmine - Defect #4725: Error displaying Project's Settings when repository configuredNew2010-02-03

Actions
Related to Redmine - Feature #1406: Browse through Git branchesClosedEric Davis2008-06-09

Actions
Actions
Copy link
 #1

Updated by André Jonsson over 13 years ago

For correctness I should probably mention that after changing the repos settings to something that is possible to connect with, delete works, of course.

Actions
Copy link
 #2

Updated by Toshi MARUYAMA over 13 years ago

  • Assignee set to Toshi MARUYAMA
Actions
Copy link
 #3

Updated by Toshi MARUYAMA over 13 years ago

Try this patch.

Actions
Copy link
 #4

Updated by André Jonsson over 13 years ago

Awesome!

However, I see that it modifies some generic part and a git-specific part (I'm not much familiar with Ruby nor the Redmine code base), but as far I've seen this problem is specific to SVN.

Of course, that doesn't exclude that this patch is the "right thing"... I'll give it a go later.

Actions
Copy link
 #5

Updated by Toshi MARUYAMA over 13 years ago

  • Target version set to 1.3.0
Actions
Copy link
 #6

Updated by André Jonsson over 13 years ago

I've tested the patch. Indeed it works!

However, I'm quite baffled as to why it works... considering it seemingly modified the behavior of managing git repositories.

Actions
Copy link
 #7

Updated by André Jonsson over 13 years ago

btw, sorry for the slow feedback; we had a long weekend over here and I was away a bit.

Actions
Copy link
 #8

Updated by Toshi MARUYAMA over 13 years ago

  • Subject changed from Delete invalid repository fails to Subversion: Delete invalid repository fails using the libsvn plugin
  • Target version deleted (1.3.0)
Actions
Copy link
 #9

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from New to Closed

Redmine subversion adapter#info returns nil if repository path is invalid.
source:tags/1.2.0/lib/redmine/scm/adapters/subversion_adapter.rb#L86

libsvn plugin adapter#info throws exception if repository path is invalid.
https://github.com/pplr/redmine-libsvn/blob/0662d754198723b6e8ad9c941d883fc5691b94f9/lib/redmine/scm/adapters/subversion_libsvn_adapter.rb#L87

This is plugin issue.

Actions
Copy link

Also available in: Atom PDF