Defect #9685
closed
Adding multiple times the same related issue relation is possible
Added by Etienne Massip about 13 years ago.
Updated almost 13 years ago.
Description
See #4911, I added relation to #7445 twice in a row with Firefox (unstable) just pressing Enter key, maybe longer than normal.
Files
- Subject changed from Adding multiple times the same related issue is possible to Adding multiple times the same related issue relation is possible
As explained in RoR documentation (both 2.3.x and 3.x, this excerpt is from 3.x'):
Concurrency and integrity
Using this validation method in conjunction with ActiveRecord::Base#save does not guarantee the absence of duplicate record insertions, because uniqueness checks on the application level are inherently prone to race conditions.
(...)
This could even happen if you use transactions with the ‘serializable’ isolation level. The best way to work around this problem is to add a unique index to the database table using (...)#add_index.
(...)
The bundled ActiveRecord::ConnectionAdapters distinguish unique index constraint errors from other types of database errors by throwing an ActiveRecord::RecordNotUnique exception. For other adapters you will have to parse the (database-specific) exception message to detect such a case.
A simple migration creating an unique index on to
and from
issue_relation
columns should do the job.
Migration patch attached.
- Target version changed from Candidate for next minor release to Candidate for next major release
Ok, since there is a migration, moving to major.
- Target version changed from Candidate for next major release to 1.4.0
- Status changed from Confirmed to Resolved
- Resolution set to Fixed
Migration committed with r8041.
- Status changed from Resolved to Closed
Also available in: Atom
PDF