Project

General

Profile

Actions

Defect #9832

closed

Revision graph height should depend on height of rows in revisions table

Added by Jakob Skjerning almost 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The new revision graph from #5501 is nice and looks fine - at least on the default theme. However, it doesn't behave well when displayed using many of the existing third party themes.

At the very least the graph should adapt to the actual height of the rows of the revisions list instead of blindly assuming a hardcoded value of 20 pixels.

The attached patch fixes this.


Files

get_height_from_rows.diff (562 Bytes) get_height_from_rows.diff Jakob Skjerning, 2011-12-18 11:55
1.3-stable-r8781.png (15.4 KB) 1.3-stable-r8781.png Toshi MARUYAMA, 2012-02-06 05:36
1.3-stable-r8796.png (17.7 KB) 1.3-stable-r8796.png Toshi MARUYAMA, 2012-02-06 05:36
theme-simple.diff (601 Bytes) theme-simple.diff Toshi MARUYAMA, 2012-02-06 05:36

Related issues

Has duplicate Redmine - Feature #9846: Provide the way for theme developers to set the row height in SCM history viewClosed

Actions
Actions #1

Updated by Jakob Skjerning almost 13 years ago

Redmine version: Redmine 1.3.0.devel.8277 (MySQL)

Output from script/about:

About your application's environment
Ruby version 1.8.7 (i686-darwin10.8.0)
RubyGems version 1.3.7
Rack version 1.1.2
Rails version 2.3.14
Active Record version 2.3.14
Active Resource version 2.3.14
Action Mailer version 2.3.14
Active Support version 2.3.14
Application root /Users/jakob/Projects/OpenSource/redmine/redmine-trunk
Environment development
Database adapter mysql
Database schema version 20111201201315

Actions #2

Updated by Toshi MARUYAMA almost 13 years ago

  • Category changed from UI to SCM
Actions #3

Updated by Toshi MARUYAMA over 12 years ago

  • Affected version (unused) changed from devel to 1.3.0
  • Affected version set to 1.3.0
Actions #4

Updated by Toshi MARUYAMA over 12 years ago

  • Target version set to 1.3.1
Actions #5

Updated by Toshi MARUYAMA over 12 years ago

These are images with attachment theme.

Actions

Also available in: Atom PDF