Project

General

Profile

Defect #33548

Updated by Mischa The Evil almost 4 years ago

Please find below a patch to fix the 'sortable?' method in QueryColumn class. 

 Currently, the method returns true if @sortable is False. 
 Therefore, some headers display a link when the column is actually not sortable (multi-value custom-fields columns in Projects page for instance). 

 Thank you for your work 

 <pre><code class="diff"> <pre> 
 diff --git a/app/models/query.rb b/app/models/query.rb 
 index 0dec7d211..c3311ffbf 100644 
 --- a/app/models/query.rb 
 +++ b/app/models/query.rb 
 @@ -51,7 +51,7 @@ class QueryColumn 
 
    # Returns true if the column is sortable, otherwise false 
    def sortable? 
 -      !@sortable.nil? 
 +      !@sortable.blank? 
    end 
 
    def sortable 
 </code></pre> </pre>

Back