Redmine

class RemoveOrphanedCustomValueAttachments < ActiveRecord::Migration[7.2]

  def up

    Attachment.where(container_type: 'CustomValue')

              .where('NOT EXISTS (SELECT 1 FROM custom_values WHERE custom_values.id = attachments.container_id)')

              .destroy_all

  end

  def down

    # no-op

  end

end

          before_destroy :store_attachment_custom_value_ids

          after_destroy :destroy_custom_value_attachments

        def store_attachment_custom_value_ids

          @attachment_custom_value_ids =

            custom_values.select {|cv| cv.custom_field.field_format == 'attachment'}

                         .map(&:id)

        end

        def destroy_custom_value_attachments

          Attachment.where(:container_id => @attachment_custom_value_ids, :container_type => 'CustomValue')

                    .destroy_all

        end

  def test_destroy_should_delete_attachments_on_custom_values

    cf = IssueCustomField.create!(:name => 'Attachable field', :field_format => 'attachment', :is_for_all => true, :tracker_ids => [1])

    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :subject => 'test', :author_id => user.id)

    attachment = Attachment.create!(:container => issue,:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => user.id)

    issue.send(

      :safe_attributes=,

      {

        'custom_fields' =>

          [

            {'id' => cf.id.to_s, 'value' => attachment.id.to_s},

          ]

      }, user

    )

    assert_difference 'CustomValue.where(:customized_type => "Issue").count', -(issue.custom_values.count) do

      assert_difference 'Attachment.count', -1 do

        issue.destroy

      end

    end

  end