Redmine

Takenori TAKAKI wrote in #note-3:

I would like to propose a patch and test code to delete the Attachment after the custom value has been removed.

Thanks. It's better than mine.

salman mp wrote in #note-4:

Takenori TAKAKI wrote in #note-3:

I would like to propose a patch and test code to delete the Attachment after the custom value has been removed.

Thanks. It's better than mine.

Thanks salman mp ! Looks like we both had the same idea around the same time. Really appreciate your feedback!

Go MAEDA wrote in #note-6:

Thank you for posting the fix. Should we add a migration to delete orphaned objects?

Good idea. Because, if that orphaned objects not destroyed here, no one will destroy them in the future even by attachment:prune rake task.

It this sufficient?

class RemoveOrphanedCustomValueAttachments < ActiveRecord::Migration[6.1]
  def up
    Attachment.where(container_type: "CustomValue").each do |a|
      a.destroy! if a.container.nil?
    end
  end

  def down
    # no-op
  end
end

Go MAEDA
I have confirmed the patch.
The added migration, proper naming and loop removal would be good!