Redmine

Hi Ki-yong Kim.

All right.
Tell the truth, I didn't understand what the "table_name_prefix" means of until yesterday. And now I understand what your point.

I will setup another redmine with table_name_prefix and will test your code. Please wait.

Hi Ki-yong.

I fixed the problem with table_name_prefix. Try this one.
http://r-labs.googlecode.com/files/redmine_code_review-0.1.8.6.zip

Thanks.

This is the translation file for Traditional Chinese.

• This is the translation file for Simple Chinese.

Andrew Liu wrote:

This is the translation file for Traditional Chinese.

Thanks. I will integrate it in next release.

jongliang zhang wrote:

• This is the translation file for Simple Chinese.

1. Sorry, I can't understand chinese.

Haru Iida wrote:

[...]

No need, that one is ok. I didn't find that before, sorry.

Code Review plugin 0.2.0 has been released by Haru Iida on 2009-07-25. See http://www.redmine.org/boards/3/topics/7646 for more details.

HTH.

Thanks for developing and maintaining such a nice plugin. It's really very useful.

But currently, the reviews can be added through diff view only. If a developer has added a new file to repository, then how can the code for that file can be reviewed? As there will not be any diff view for newly added file!

It should also support new files, not just diffs, did you really try?

Hi Paryank, Marcel.

It should also support new files, not just diffs, did you really try?

I will do try it. Wait a while.

Hi Haru,

I have tried it. I have installed version 0.2.0 on Redmine version 0.8.4. I cannot see diff for new files. I can view diff for modified files only. For new files, I have to see file view page not diff page. On file view page I cannot see icons to add code review.

It's working correctly on the URLs like:
http://redmine.myserver.com/repositories/diff/<project_identifier>/<repository_file_path>?rev=<revision_number>

But I cannot see it on the URLs like:
http://redmine.myserver.com/repositories/entry/<project_identifier>/<repository_file_path>

Can you please guide me if I am missing something?

Thanks

Hi Paryank.

I apologize that I confused you because of my poor English.
You can't add review for newly added file yet.
I'm starting to implement it just now. So please wait for another release.

Regards.

Hi Paryank, Marcel.

I released the Code Review Plugin 0.2.2 and you can add review for new file at last.
Try this.

http://www.redmine.org/boards/3/topics/7646#message-7881

Thanks.

Hi Haru,

Thanks a lot for your so much efforts and considering our requirements. Code review on new file works fine.

Thanks again.

High, I've made slovak translation for your plugin, if you are interested. It is added as an attachment to my post.

Milan Freml wrote:

High, I've made slovak translation for your plugin, if you are interested. It is added as an attachment to my post.

I've re-posted your contribution under the new thread at http://www.redmine.org/boards/3/topics/9627#message-9711.

Thanks for sharing...

I'll lock this topic to prevent further distinction of the forum messages in different threads.

New, updated thread where further discussion about the plugin is welcome can be found at http://www.redmine.org/boards/3/topics/9627.

 
Kind regards,

Mischa.