Code Review Plugin
Added by Haruyuki Iida over 15 years ago
Hi. Let me announce to you My "Code Review Plugin" .It makes you can write code reviews of committed source code on Redmine's "Diff" page of repository browser.
like this...
Adding review.¶
Showing reviews.¶
I tested this plugin on Redmine 0.8.3 and current trunk.
I hope you will like this plugin. Thanks.
add_review.png (21.4 KB) add_review.png | Adding rview | ||
show_reviews.png (45 KB) show_reviews.png | Showing reviews |
Replies (118)
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
Hi Ki-yong Kim.
All right.
Tell the truth, I didn't understand what the "table_name_prefix" means of until yesterday. And now I understand what your point.
I will setup another redmine with table_name_prefix and will test your code. Please wait.
Code Review Plugin 0.1.8.6 Released.
-
Added by Haruyuki Iida about 15 years ago
Hi Ki-yong.
I fixed the problem with table_name_prefix. Try this one.
http://r-labs.googlecode.com/files/redmine_code_review-0.1.8.6.zip
Thanks.
RE: Code Review Plugin
-
Added by Andrew Liu about 15 years ago
This is the translation file for Traditional Chinese.
RE: Code Review Plugin
-
Added by Jiongliang Zhang about 15 years ago
- This is the translation file for Simple Chinese.
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
Andrew Liu wrote:
This is the translation file for Traditional Chinese.
Thanks. I will integrate it in next release.
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
jongliang zhang wrote:
Thanks. But zh.yml is already exists in a current release.
- This is the translation file for Simple Chinese.
Should I replace it with your one ?
- Sorry, I can't understand chinese.
RE: Code Review Plugin
-
Added by Jiongliang Zhang about 15 years ago
Haru Iida wrote:
[...]
No need, that one is ok. I didn't find that before, sorry.
RE: Code Review Plugin
-
Added by Mischa The Evil about 15 years ago
Code Review plugin 0.2.0 has been released by Haru Iida on 2009-07-25. See http://www.redmine.org/boards/3/topics/7646 for more details.
HTH.
RE: Code Review Plugin
-
Added by Paryank Kansara about 15 years ago
Thanks for developing and maintaining such a nice plugin. It's really very useful.
But currently, the reviews can be added through diff view only. If a developer has added a new file to repository, then how can the code for that file can be reviewed? As there will not be any diff view for newly added file!
RE: Code Review Plugin
-
Added by Ammler _ about 15 years ago
It should also support new files, not just diffs, did you really try?
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
Hi Paryank, Marcel.
It should also support new files, not just diffs, did you really try?
I will do try it. Wait a while.
RE: Code Review Plugin
-
Added by Paryank Kansara about 15 years ago
Hi Haru,
I have tried it. I have installed version 0.2.0 on Redmine version 0.8.4. I cannot see diff for new files. I can view diff for modified files only. For new files, I have to see file view page not diff page. On file view page I cannot see icons to add code review.
It's working correctly on the URLs like:
http://redmine.myserver.com/repositories/diff/<project_identifier>/<repository_file_path>?rev=<revision_number>
But I cannot see it on the URLs like:
http://redmine.myserver.com/repositories/entry/<project_identifier>/<repository_file_path>
Can you please guide me if I am missing something?
Thanks
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
Hi Paryank.
I apologize that I confused you because of my poor English.
You can't add review for newly added file yet.
I'm starting to implement it just now. So please wait for another release.
Regards.
RE: Code Review Plugin
-
Added by Haruyuki Iida about 15 years ago
Hi Paryank, Marcel.
I released the Code Review Plugin 0.2.2 and you can add review for new file at last.
Try this.
http://www.redmine.org/boards/3/topics/7646#message-7881
Thanks.
RE: Code Review Plugin
-
Added by Paryank Kansara about 15 years ago
Hi Haru,
Thanks a lot for your so much efforts and considering our requirements. Code review on new file works fine.
Thanks again.
Slovak translation
-
Added by Milan Freml over 14 years ago
High, I've made slovak translation for your plugin, if you are interested. It is added as an attachment to my post.
RE: Slovak translation
-
Added by Mischa The Evil over 14 years ago
Milan Freml wrote:
High, I've made slovak translation for your plugin, if you are interested. It is added as an attachment to my post.
I've re-posted your contribution under the new thread at http://www.redmine.org/boards/3/topics/9627#message-9711.
Thanks for sharing...
RE: Code Review Plugin
-
Added by Mischa The Evil over 14 years ago
I'll lock this topic to prevent further distinction of the forum messages in different threads.
New, updated thread where further discussion about the plugin is welcome can be found at http://www.redmine.org/boards/3/topics/9627.
Kind regards,
Mischa.
- « Previous
- 1
- …
- 3
- 4
- 5
- Next »