Redmine

Sorry, 0.2.7 has a problem. Please use 0.2.8.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.8.zip

Fixed bug.

• Can't open a code review setting menu.

Regards.

0.2.8 has another problem with Redmine 0.8.7.

Please use 0.2.9.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.9.zip

Fixed bug:

• Authentication error occurs when you use Redmine 0.8.7

Regards.

Extracted from old plugin forum-thread at http://www.redmine.org/boards/3/topics/5878#message-9699:

Subject: Slovak translation - Added by Milan Freml on 2009-11-19, 15:08

Hi, I've made slovak translation for your plugin, if you are interested. It is added as an attachment to my post.

This is now the active, main forum-thread about the Code Review plugin.

• Dedicated to Code Review plugin 0.1.0 > 0.2.0: http://www.redmine.org/boards/3/topics/5878
• Dedicated to Code Review plugin 0.2.0 > 0.2.7: http://www.redmine.org/boards/3/topics/7646

Mischa The Evil wrote:

This is now the active, main forum-thread about the Code Review plugin.

It's predecessors were:

• Dedicated to Code Review plugin 0.1.0 > 0.2.0: http://www.redmine.org/boards/3/topics/5878
• Dedicated to Code Review plugin 0.2.0 > 0.2.7: http://www.redmine.org/boards/3/topics/7646

Thank you Mischa.
The jobs that you have done for this site are really great.

Code Review Plugin 0.2.9.1 Released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.9.1.zip

Feature:

• Slovak translation was added. Thanks Milan Freml.

Fixed bug:

• Debug message was displayed when you replied to review.

Regards.

Hi Haru,

There is a minor problem I encounter when printing the PDF report of an issue: if it's a Code Review issue, the Code Review information is not printed in the report. Are you looking into enhancing this?

P/S - We're currently using your Code Review in our work and it's working great. You've done a great job! :)

Hello, great thanks for your plugin, it's great.

We are trying to start using it, but there is one trouble, preventing us.

We have added required custom field to issues «client». When code review task is being created is's required to fill this custom field, but there is no field on the form.

How can this trouble be solved?

Ryan Phung wrote:

There is a minor problem I encounter when printing the PDF report of an issue: if it's a Code Review issue, the Code Review information is not printed in the report. Are you looking into enhancing this?

Hi Ryan, Thank you for your comment.

I have tried to solve this problem but I still haven't find the way.
It seems to take time for a while.

Mike Ozornin wrote:

We have added required custom field to issues «client». When code review task is being created is's required to fill this custom field, but there is no field on the form.

How can this trouble be solved?

Hi Mike,

You can't add review with required custom field now. I will examine how I could resolve the problem.

New Code Review Plugin was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.9.2.zip

Features:

• Spanish translation was added.
• German translation was updated.

Fixed bugs:

• Empty review form shows up at the page bottom when cancel button of review form was pressed.
  bottom.
• sometimes error "undefined method `[]' for nil:NilClass" shows up when trying to annotate a file.

Hello.

Installed 0.2.9.2 version of the plugin.
Running latest trunk version of REDMINE in Development mode (not production).

Enabled the plugin for my project and set the permissions accordingly (view, add, edit, delete, settings). I am not able to see any pencil icon, and am not able to see any type of code review tab.

Ran db:migrate_plugins after dropping the plugin source into the vendor/plugins directory. There were not any errors, and I am able to see the plugin listed on my plugins page, and could also see it on the modules tab for the project specific settings. I have seen similar posts in the past for this problem, but never any useful replies.

Any recommendations? No errors in the logs, not errors on the page. Just looks like the plugin is not working. Need some help on where I should look first. Thanks!

I like to know whats the compatibility of plugin with the scm in redmine. I can running in subversion but in my git repository this erro happen.

NoMethodError in Code reviewController#update_diff_view

undefined method `changes' for nil:NilClass

RAILS_ROOT: F:/Users/thales/workspace/redmine-gingacdn-trunk
Application Trace | Framework Trace | Full Trace

F:/Users/thales/workspace/redmine-gingacdn-trunk/vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:161:in `update_diff_view'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/base.rb:1331:in `send'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/base.rb:1331:in `perform_action_without_filters'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/filters.rb:617:in `call_filters'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/filters.rb:610:in `perform_action_without_benchmark'

Thanks in advance.

Nick Knize wrote:

Hello.

Installed 0.2.9.2 version of the plugin.
Running latest trunk version of REDMINE in Development mode (not production).

Any recommendations? No errors in the logs, not errors on the page. Just looks like the plugin is not working. Need some help on where I should look first. Thanks!

Just been setting up myself - encountered the same problem - fixed for me by ensuring that all the directories and files in redmine_code_review were at least readable/executable for all users. I don't necessarily endorse this as a sensible thing to do :) but it did make the plugin visible.

I guess either I've got the wrong user/group or it genuinely needs to be globally readable.

Thales Ferreira wrote:

I like to know whats the compatibility of plugin with the scm in redmine. I can running in subversion but in my git repository this erro happen.

NoMethodError in Code reviewController#update_diff_view

undefined method `changes' for nil:NilClass

RAILS_ROOT: F:/Users/thales/workspace/redmine-gingacdn-trunk
Application Trace | Framework Trace | Full Trace

F:/Users/thales/workspace/redmine-gingacdn-trunk/vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:161:in `update_diff_view'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/base.rb:1331:in `send'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/base.rb:1331:in `perform_action_without_filters'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/filters.rb:617:in `call_filters'
c:/ruby/lib/ruby/gems/1.8/gems/actionpack-2.3.4/lib/action_controller/filters.rb:610:in `perform_action_without_benchmark'

I am getting the same error with my git repositories. To give you a little more context, here is the actual error:

NoMethodError (undefined method `changes' for nil:NilClass):
vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:161:in `update_diff_view'

It is referring to the Changeset class which is a dependency. I would like to know what the ChangeSet dependency is and where I can grab it from. I saw a patch for it in the code, but wasn't sure where to get the original source. The same thing goes for the Changes dependency.

Regards,

Nate Lowrie

Code Review Plugin 0.2.9.3 was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.9.3.zip

fixed bug:

• Error occurs with git repository on trunk redmine.

Thales Ferreira, Nate Lowrie, thanks for your reporting.

Regards.

Haru,

That fixes my issues. On another note, is the code review pencils supposed to show up if the commit isn't related to a specific tracker or should it show up all the time?

Regards,

Nate

Hi,

I'm wondering if anyone can help me. I got code review plugin setup, but I'm not sure how I can start a code review. Let's say I have an issue #1 opened, bunch of files modified and ready for review. I know that I can specify refs/closes to the check in message, but I would also like the code to be reviewed before the issue is closed. Can anyone give me a list of steps to create a code review specifically for #1?

Thanks for the great plug-in!

Regards,

Hello! First of all, thanks for the plugin, very useful :)

I have a minor problem though,
in the Opera browser the review popup window moves kinda strange.. When I drag the cursor to one position the window moves to another. The problem appears in the latest code review plugin version (0.2.9.3) and latest Opera 10.10 on both Windows and MacOS. Is it possible to solve the issue?

Thanks in advance!

Blue Fox wrote:

Hi,

I'm wondering if anyone can help me. I got code review plugin setup, but I'm not sure how I can start a code review. Let's say I have an issue #1 opened, bunch of files modified and ready for review. I know that I can specify refs/closes to the check in message, but I would also like the code to be reviewed before the issue is closed. Can anyone give me a list of steps to create a code review specifically for #1?

Thanks for the great plug-in!

Regards,

Hi Blue Fox,

Guess I would be able to answer some of your queries, to my humble knowledge.
- Firstly you need to enable the Code Review (in Project Setting, Code Review tab).
- After that, browse your repository and view the file you would like to review. You need to view a specific version of the file.
- Click on the Code Review icon on the line you would like to add the review comment, and a pop-up window should come up. Fill in the details and save the review. It will become a new issue.
- As far as I know, you can not create a code review specifically for an existing issue. As I mention above if you create a code review, a new issue will be created.

Hope it helps; and if anyone find out that I'm wrong at any point I would be glad to be corrected!

Haru,

I've got the trunk version and it's seems work perfectly with redmine 0.9.0 but the edit icon doesn't appears in diff pages... The trunk version works with redmine 0.9.0?

Hi Vinicius,

Vinicius Diniz wrote:

Haru,

I've got the trunk version and it's seems work perfectly with redmine 0.9.0 but the edit icon doesn't appears in diff pages... The trunk version works with redmine 0.9.0?

Yes, it works.
Did you select the tracker for code review at project setting page?
Does your redmine run in production mode?

Haru,

Yes and yes.

Now it works. I just saved code review settings without any change and now it works!

Thanks!

for anyone having the problem that the pencil wont show up:
check your file permissions and fix the directory public/plugin_assets

that might help as well:
tail -f log/production.log

I have recently upgraded my redmine to version 0.9.3. Now I am getting error on project settings page for which code review is enabled. I have attached exception trace from my log file. I am not a Rails genius :-) so couldn't find the cause of error. Can anyone help for this?