Project

General

Profile

Actions

Patch #1028

closed

Clean up timelog code

Added by Rocco Stanzione over 16 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Time tracking
Target version:
-
Start date:
2008-04-09
Due date:
% Done:

0%

Estimated time:

Description

This doesn't have any effect on functionality, but "criteria" is the plural of "criterion", so there's no such word as "criterias". This makes the code difficult to read/work with for a (pedantic) native English speaker. Cleans up the timelog helper, views, controller and functional tests. Tests pass.


Files

cleanup_timelog.diff (14.6 KB) cleanup_timelog.diff Rocco Stanzione, 2008-04-09 21:54
Actions #1

Updated by Toshi MARUYAMA over 13 years ago

  • Category set to Time tracking
Actions #2

Updated by Daniel Felix almost 12 years ago

  • Assignee set to Toshi MARUYAMA

Well, I think this one could be closed. As I see for now, there is nothing like criterias or something similar. The patched method is completly rewritten, as I could see.

@ Toshi: If you have no reason against it, this could be set to closed. :-)

Actions #3

Updated by Jean-Philippe Lang almost 12 years ago

  • Status changed from New to Closed

Indeed, the patch is obsolete. The proposed change (criterias => criteria) was part of r8026.

Actions #4

Updated by Toshi MARUYAMA almost 12 years ago

  • Assignee deleted (Toshi MARUYAMA)
Actions

Also available in: Atom PDF