Actions
Patch #11497
closedDry up logging in MailHandler class
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email receiving
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Description
The current approach to logging in MailHandler is a bit funny. Instead of checking "if logger
" every time, just make sure logger
returns non-nil
.
Also, extra-checking with "if logger && logger.info
" doesn't make much sense. It prints extra blank lines when logger is set and accepts info level, but has no point when level setting is different. It's perfectly safe to just call "logger.info message
".
Files
Related issues
Updated by Go MAEDA almost 6 years ago
- Related to Defect #30457: MailHandler.safe_receive does not output any error log added
Actions