Project

General

Profile

Actions
Copy link

Feature #12228

closed

JRuby 1.7.2 support

Added by Jean-Philippe Lang about 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Ruby support
Target version:
2.3.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Files

Download all files
settings500.png (30.7 KB) settings500.png xt zhang, 2012-11-03 17:45
jruby-openssl.diff (321 Bytes) jruby-openssl.diff epicmonkey ., 2012-11-28 21:46
pg_jruby1.7.2_mode1.9.png (9.63 KB) pg_jruby1.7.2_mode1.9.png Etienne Massip, 2013-01-30 15:23

Related issues

Related to Redmine - Defect #8825: JRuby + Windows: SCMs do not work on Redmine 1.2ClosedToshi MARUYAMA2011-07-15

Actions
Related to Redmine - Defect #13044: Rake error using JRuby 1.7.2 and Redmine trunk Closed

Actions
Actions
Copy link
 #1

Updated by Jean-Philippe Lang about 12 years ago

CVS tests fails with JRuby on Windows:
  • @repository.fetch_changesets only loads 5 changesets (instead of 7)
  • rake test dies on test\functional\repositories_cvs_controller_test.rb
Actions
Copy link
 #2

Updated by Jean-Philippe Lang about 12 years ago

Toshi, that would be great if you could have a look at the CVS issues with JRuby.

Actions
Copy link
 #3

Updated by Toshi MARUYAMA about 12 years ago

CVS tests pass on my Fedora 13.

$ jruby --version
jruby 1.7.0 (1.9.3p203) 2012-10-22 ff1ebbe on OpenJDK 64-Bit Server VM 1.6.0_18-b18 [linux-amd64]

CVS tests fails on Windows JRuby 1.6.
See #8825#note-2.

Actions
Copy link
 #4

Updated by xt zhang about 12 years ago

When using JRuby 1.7.0 and setting the account Language to Simplified Chinese, an internal error occurred on the Admin's settings page. When setting the Language to English, the page is ok.

Started GET "/settings" for 127.0.0.1 at 2012-11-04 00:41:00 +0800
Processing by SettingsController#index as HTML
  Current user: admin (id=1)
  Rendered settings/_general.html.erb (69.0ms)
  Rendered settings/_display.html.erb (103.0ms)
  Rendered common/_tabs.html.erb (248.0ms)
  Rendered settings/edit.html.erb within layouts/admin (262.0ms)
Completed 500 Internal Server Error in 315ms

ActionView::Template::Error (incompatible character encodings: UTF-8 and GBK):
    9: <% locale = User.current.language.blank? ? ::I18n.locale : User.current.language %>

    10: <p><%= setting_select :date_format, Setting::DATE_FORMATS.collect {|f| [::I18n.l(D
ate.today, :locale => locale, :format => f), f]}, :blank => :label_language_based %></p>
    11:
    12: <p><%= setting_select :time_format, Setting::TIME_FORMATS.collect {|f| [::I18n.l(T
ime.now, :locale => locale, :format => f), f]}, :blank => :label_language_based %></p>
    13:
    14: <p><%= setting_select :user_format, @options[:user_format] %></p>
    15:
  app/helpers/settings_helper.rb:38:in `setting_select'
  app/views/settings/_display.html.erb:12:in `_app_views_settings__display_html_erb__23830
1203_16264'
  app/views/settings/_display.html.erb:1:in `_app_views_settings__display_html_erb__238301
203_16264'
  app/views/common/_tabs.html.erb:24:in `_app_views_common__tabs_html_erb___1980793840_161
06'
  app/views/common/_tabs.html.erb:23:in `_app_views_common__tabs_html_erb___1980793840_161
06'
  app/helpers/application_helper.rb:259:in `render_tabs'
  app/views/settings/edit.html.erb:3:in `_app_views_settings_edit_html_erb__1640461337_161
02'
  app/controllers/settings_controller.rb:26:in `index'

Environment:
  Redmine version                          2.1.2.stable
  Ruby version                             1.9.3 (java)
  Rails version                            3.2.8
  Environment                              production
  Database adapter                         MySQL
Redmine plugins:
  no plugin installed
Actions
Copy link
 #5

Updated by Terence Mill about 12 years ago

+1

Actions
Copy link
 #6

Updated by epicmonkey . almost 12 years ago

Per Codehaus ticket http://jira.codehaus.org/browse/JRUBY-6961 jruby-openssl is bundled with jruby-1.7.x now; furthermore if you try to require and use jruby-openssl on jruby-1.7.0 it will raise an exception "private method `verify_mode=' for OpenSSL::SSL::"

However we can check JRuby version in Gemfile prior warbling and bundling Redmine:

gem "jruby-openssl" if JRUBY_VERSION < '1.7.0'.

Attached diff file to address this.

HTH

Actions
Copy link
 #7

Updated by Jean-Philippe Lang almost 12 years ago

JRuby 1.7.0 added to the CI server.

Actions
Copy link
 #8

Updated by Jean-Philippe Lang almost 12 years ago

epicmonkey . wrote:

Per Codehaus ticket http://jira.codehaus.org/browse/JRUBY-6961 jruby-openssl is bundled with jruby-1.7.x now; furthermore if you try to require and use jruby-openssl on jruby-1.7.0 it will raise an exception "private method `verify_mode=' for OpenSSL::SSL::"

However we can check JRuby version in Gemfile prior warbling and bundling Redmine:

The provided patch breaks with non-JRuby interpreters as JRUBY_VERSION is not defined. Fixed patch committed in r10955.

Actions
Copy link
 #9

Updated by Jean-Philippe Lang almost 12 years ago

FWIW, tests fail on the CI server with JRuby 1.7.0 because of http://jira.codehaus.org/browse/JRUBY-7038 that occurs when running the database migration.

Actions
Copy link
 #10

Updated by Terence Mill almost 12 years ago

Jean-Philippe Lang wrote:

FWIW, tests fail on the CI server with JRuby 1.7.0 because of jira.codehaus.org/browse/JRUBY-7038 that occurs when running the database migration.

I succeeded with migration from redmine 1.3 to redmine 2.1, mysql 5+jdbc on opensuse 11.4 rvm =* jruby-1.7.0 [ i386 ]
Must be special case bug.

Actions
Copy link
 #11

Updated by Jean-Philippe Lang almost 12 years ago

  • Subject changed from JRuby 1.7.0 support to JRuby 1.7 support
Actions
Copy link
 #12

Updated by Jean-Philippe Lang almost 12 years ago

After a few more fixes, r11280 passes the tests suite with JRuby 1.7.2.

Actions
Copy link
 #13

Updated by Etienne Massip almost 12 years ago

There have been numerous improvements in the AR-PG JDBC bridge, is RM still unusable with it?

Actions
Copy link
 #14

Updated by Etienne Massip almost 12 years ago

Etienne Massip wrote:

There have been numerous improvements in the AR-PG JDBC bridge, is RM still unusable with it?

Actions
Copy link
 #15

Updated by Jean-Philippe Lang almost 12 years ago

Tests with PostgreSQL and JRuby1.7.2 have been running on the Redmine CI server for a few days, and it's greeen:

http://www.redmine.org/builds/index.html

Actions
Copy link
 #16

Updated by Etienne Massip almost 12 years ago

Jean-Philippe Lang wrote:

Tests with PostgreSQL and JRuby1.7.2 have been running on the Redmine CI server for a few days, and it's greeen:

http://www.redmine.org/builds/index.html

Miss them, good news =)

Actions
Copy link
 #17

Updated by Jean-Philippe Lang almost 12 years ago

  • Subject changed from JRuby 1.7 support to JRuby 1.7.2 support
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 2.3.0
  • Resolution set to Fixed
Actions
Copy link
 #18

Updated by Etienne Massip almost 12 years ago

  • Status changed from Closed to Reopened

Because of #13044.

Actions
Copy link
 #19

Updated by Etienne Massip almost 12 years ago

Jean-Philippe Lang wrote:

Tests with PostgreSQL and JRuby1.7.2 have been running on the Redmine CI server for a few days, and it's greeen:

http://www.redmine.org/builds/index.html

Wouldn't it work with JRuby 1.6 too?

Actions
Copy link
 #20

Updated by Jean-Philippe Lang almost 12 years ago

  • Status changed from Reopened to Closed

Etienne Massip wrote:

Because of #13044.

#13044 is a JRuby/rake/Win32 issue.

Actions
Copy link

Also available in: Atom PDF