Patch #12730

Fix sorting and PDF output of Gantt diagram & start date calculation and grouping

Added by Tobias Droste over 8 years ago. Updated over 6 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Gantt
Target version:Candidate for next major release

Description

This patch does several things:

  1. Fixes the sorting of issues so that the oldest one are on top and the newer ones are at the bottom
  2. Fixes the PDF output for short items where the length of the bar would be 0 or negative with the old calculation
  3. If no start date is given the date of the first issue in the query is used and the month count is set to include all issues (max. 48)
  4. Keeps the query from other views and respects the grouping to group items in the diagram too (see Screenshot). If a query has no grouping the view is the same as in the original version.

It passes all test that are available for the Gantt diagram.

(I could split it into 4 patches and provide more screenshots if there's interest)

gantt_diagram.diff Magnifier - Patch for Gantt diagram (18.5 KB) Tobias Droste, 2013-01-04 10:08

grouped_gantt_diagram.png - Screenshot of a grouped diagram (by priority) (53.4 KB) Tobias Droste, 2013-01-04 10:08

Fix-PDF-output-of-Gantt-diagram-for-small-tickets.patch Magnifier - Patch to fix PDF output of Gantt diagram with small ticket durations (4.46 KB) Tobias Droste, 2013-01-05 09:29

Gantt-Calculate-month-from-and-count-from-current-query.patch Magnifier - Patch to calculate start month and month count from the current query (4.55 KB) Tobias Droste, 2013-01-05 09:29

Related issues

Related to Redmine - Feature #347: Grouping issues in Gantt view New
Related to Redmine - Feature #4786: Gantt Chart - Grouping issues by target version Closed 2010-02-10
Related to Redmine - Feature #7836: Ability to save Gantt query filters Closed 2011-03-11
Related to Redmine - Defect #8366: Gantt Version Ordering Closed 2011-05-13
Related to Redmine - Feature #9565: Gantt graph grouped by "assigned to" New 2011-11-14
Related to Redmine - Feature #11293: Order/Group tasks by users on Gantt New
Related to Redmine - Defect #7335: Sorting issues in gantt by date, not by id Closed 2011-01-15
Related to Redmine - Defect #11840: trouble with gantt New
Related to Redmine - Defect #6407: New gantt charts shouldn't display all issues / versions Closed 2010-09-16

History

#1 Updated by Tobias Droste over 8 years ago

This (mostly) fixes following tickets:

#2 Updated by Daniel Felix over 8 years ago

Hi Tobias,

thanks for this patch and your search.

I added the relations. I will try this patch and give a short feedback.

Best regards,
Daniel

#3 Updated by Daniel Felix over 8 years ago

Hi,

the path works good. But the grouping of gantt doesn't seem to work?
I tested this with r11114.

I also tried this in combination with #3436. Which seems to work, after a manual merge.

Some UI enhancements:
- the grouping box should be hidden by default as in every other modul

Best regards,
Daniel

#4 Updated by Toshi MARUYAMA over 8 years ago

Tobias Droste wrote:

(I could split it into 4 patches and provide more screenshots if there's interest)

Please split and post it to each issues.

#5 Updated by Tobias Droste over 8 years ago

Toshi MARUYAMA wrote:

Please split and post it to each issues.

Ok.

Daniel Felix wrote:

the path works good. But the grouping of gantt doesn't seem to work?
I tested this with r11114.

It should work, I tested it with r11113.
As Toshi MARUYAMA suggested I will split the patch.
And I make some additional changes to the grouping.
So see this patch as deprecated for now.

Daniel Felix wrote:

Some UI enhancements:
- the grouping box should be hidden by default as in every other modul

I will change that.

Thanks for the feedback and testing and I will post a new split version to the corresponding tickets. (Probably tomorrow)

#6 Updated by Tobias Droste over 8 years ago

I'm attaching the patch to fix PDF output and the patch to calculate 'month from' and 'month count' here, because there are no tickets for this yet.

The other two are attached to these two tickets:
#347
#8366

#7 Updated by Daniel Felix over 8 years ago

Thank you for your great work. I will try your patches soon (this weekend or maybe monday). Thank you for your work!

#8 Updated by Daniel Felix over 8 years ago

  • Assignee set to Jean-Philippe Lang
  • Target version set to Candidate for next major release

Maybe Toshi or Jean-Philippe could take a look at the provided patches.
Would be nice to see this fixed. I tried most of them in my Redmine 2.2.1 and they work properly.

#9 Updated by Dominik Follmann over 8 years ago

Hi folks,
how is the status of this issue? As Daniel Felix said, he tested the patch successful. Is there a certain reason, why it won't be included in the next major release (2.3.0) ?
I guess lots of people are facing these problems (mainly the gantt-sorting). It would be nice if someone would give an update.
I'm not a good ruby-hacker yet, but if I can support you with some tests or so, I'm available.
Regards
Dominik

#10 Updated by Toshi MARUYAMA over 8 years ago

Dominik Follmann wrote:

Is there a certain reason, why it won't be included in the next major release (2.3.0) ?

There is no test.
source:trunk/test/unit/lib/redmine/helpers/gantt_test.rb@11559

#11 Updated by Sebastian Paluch over 6 years ago

+1

Also available in: Atom PDF