Defect #13036
closed
auto generated comment "Applied in changeset xxx" is not link to commit
Added by Bảo Gia over 11 years ago.
Updated about 9 years ago.
Description
It should be:
"Applied in changeset commit:repoid|hash."
Not:
"Applied in changeset repoid|commit:hash."
Files
I can confirm this.
I guess the extended syntax is intentional, because now more then 1 repository per project are allowed. With svn repos, that means the repo must be included in the commit macro in order to uniquely identify the commit.
However the macro isn't expanded to a link if it contains the repo.
Redmine version here: 2.2.2.stable
seems to be a duplicate of #13005
Dietmar Hofer wrote:
seems to be a duplicate of #13005
No. #13005 is abount repoid "contains underscores"
Dietmar Hofer wrote:
I guess the extended syntax is intentional, because now more then 1 repository per project are allowed. With svn repos, that means the repo must be included in the commit macro in order to uniquely identify the commit.
No. This is a bug, not "intentional".
It should be "commit:repoid|hash" (have repoid => can support >1 repo per project)
Attached is a patch to fix this. Unlike the patch in #12685 this works for both hash-based and non-hash based (e.g. subversion) revisions, and includes a unit test for the hash-based case (the non-hash based case already has a test).
Thanks for providing a patch!
I would like to test it but I can't. I'm currently at hospital. Maybe someone can check this. Maybe this one could find its way in 2.2.4/2.3 in a fast pace if it could be evaluated! :-)
Hi, I can confirm this bug. I've tested both patches (i.e. this one and the one from #12685) on Redmine 2.4.0, they both work. Please merge this.
Though I suggest some logical cleanup, i.e. | is not part of the repo id. The very slightly modified patch is attached.
- Status changed from New to Closed
- Resolution set to Duplicate
- Is duplicate of Defect #13544: Commit reference: autogenerated issue note has wrong commit link syntax in multi-repo or cross-project context added
Also available in: Atom
PDF