Redmine

• Please use two spaces instead of tabs for intends.
• Please use "javascript_tag" instead of <script type="text/javascript">, refer r10371.
• I think that Rails validates_format_of is better than JS.
  refer: source:tags/2.3.0/app/models/repository/subversion.rb#L23

1. & 2. agreed

3. this script is in thought in addition to the normal validation. The rails validation works after submitting. This script check before the user try to save anything. A combination would be good, as the user won't be bothered to submit each config x-times.

Yes there should be some validation via rails, but this won't be a live check anyway.
The user just can try and error until everything is fine. The frontend should provide a feedback to the client.

By the way, I would prefer this

v = v.gsub(/#{@available_settings[name]['regexp']}/i,'') unless @available_settings[name]['regexp'].blank? && v.blank?

instead of this:

v = v.gsub(/#{@available_settings[name]['regexp']}/i,'') if !@available_settings[name]['regexp'].blank? && !v.blank?

There would be less confusion because of the ommitting of the negotiation.

If you want to use unless it would be:

v = v.gsub(/#{@@available_settings[name]['regexp']}/i,'') unless @@available_settings[name]['regexp'].blank? || v.blank?

Filou Centrinov wrote:

If you want to use unless it would be:
[...]
(De Morgan's law)

Why @? should be enough? You haven't changed anything instead of your double @?

You haven't changed anything instead of your double @?

I changed your logical conjunction. If you use unless you have to use || instead of && because of De Morgan's law.

Ah thanks. I haven't noticed the or. :-) this happens if you try to watch at something while your on the jump to your next meeting. :-)

Hi there,

any news on this hostname validation patch?

I recently noticed this stumbling block as a friend of mine tried to install Redmine in his company.

Best regards,
Daniel