Patch #13774
closed
Show warning if CSV-Export exceeds limit
Added by Daniel Felix over 11 years ago.
Updated over 10 years ago.
Description
Hi there,
Filou Centrinov has reported a feature request in #13770. This patch aims to fix this.
Best regards,
Daniel
Files
Three translation suggestions:
1st: EN: Export contains only %{export} of %{total} issues.
2nd: EN: Export contains only the first %{export} of %{total} issues.
3rd: EN: Export limit is {X}.
Also the pdf export needs a warning. I know, there is no dialog by default.
I think like this it would be more simple and logical:
<% if @issue_count > @csv_limit %>
<div class="flash warning">
<%= l(:warning_export_limit, :export => @csv_limit, :total => @issue_count) %>
</div>
<% end %>
Hi Filou,
your right the condition could be changed in this order. Well the result will be the same. :-)
I changed this in the patch.
In addition, I removed the .min. I added it in the first version (not uploaded here) to always display the count of the exported issues.
I changed the size of the modalbox and changed the translation to your suggestion nr. 1 in note 1.
If anyone has translations for this in his language, please provide them. I'll include them in the patch.
Best regards,
Daniel
Any news on this? Is this patch okay?
- Assignee set to Jean-Baptiste Barth
Seems ok at first sight, but needs a test or two so we won't break it inadvertently in a future release. I assign the issue to myself, I'll test it and write some tests tomorrow (except if you want to do so Daniel, would be great ;-))
Just one thing though, I'm always reluctant to add new locale keys (locale maintenance is a tiny nightmare). Isn't it possible to use the already existing setting_issues_export_limit
?
- Subject changed from Show warning if CSV-Export exceeds limits. to Show warning if CSV-Export exceeds limit
- Status changed from New to Closed
- Assignee changed from Jean-Baptiste Barth to Jean-Philippe Lang
- Target version set to 2.5.0
Feature added in r12663. I used the existing i18n string and added some tests.
Also available in: Atom
PDF