Defect #14737
closed
Gantt, completed % truncated instead of rounded
Added by Jérôme BATAILLE over 11 years ago. Updated over 10 years ago.
0%
Files
| RM_14737_gantt_completed_pourcent_truncated.diff (834 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff | Jérôme BATAILLE, 2013-08-21 16:23 | ||
| RM_14737_gantt_completed_pourcent_truncated.diff (778 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff | Jérôme BATAILLE, 2013-08-22 15:29 | ||
| edit.png (6 KB) edit.png | Toshi MARUYAMA, 2014-05-14 13:45 | ||
| view.png (5.79 KB) view.png | Toshi MARUYAMA, 2014-05-14 13:45 |
Related issues
Updated by Jérôme BATAILLE over 11 years ago
- File RM_14737_gantt_completed_pourcent_truncated.diff RM_14737_gantt_completed_pourcent_truncated.diff added
Here is a patch
Updated by Daniel Felix over 11 years ago
+1 to the patch.
But English comments would be better. ;-)
Updated by Jérôme BATAILLE over 11 years ago
- File RM_14737_gantt_completed_pourcent_truncated.diff RM_14737_gantt_completed_pourcent_truncated.diff added
Sorry :-)
Updated by Jérôme BATAILLE over 10 years ago
Any chance that this very simple patch could be integrated to the core ?
Updated by Toshi MARUYAMA over 10 years ago
This problem is not only pdf but also web form.
diff --git a/app/views/issues/_attributes.html.erb b/app/views/issues/_attributes.html.erb
--- a/app/views/issues/_attributes.html.erb
+++ b/app/views/issues/_attributes.html.erb
@@ -63,7 +63,7 @@
<% end %>
<% if @issue.safe_attribute? 'estimated_hours' %>
-<p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
+<p><%= f.text_field :estimated_hours, :size => 10, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
<% end %>
<% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>
Updated by Jérôme BATAILLE over 10 years ago
Hi Toshi,
You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.
Updated by Toshi MARUYAMA over 10 years ago
Jérôme BATAILLE wrote:
Hi Toshi,
You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.
Sorry, I confused with #12510#note-15.
Updated by Toshi MARUYAMA over 10 years ago
- Target version changed from 2.5.2 to 2.6.0
Updated by Toshi MARUYAMA over 10 years ago
- Related to Feature #13442: Gantt : rounding error for version completed percent added
Updated by Toshi MARUYAMA over 10 years ago
- Related to deleted (Feature #13442: Gantt : rounding error for version completed percent)
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Feature #13442: Gantt : rounding error for version completed percent added
Updated by Toshi MARUYAMA over 10 years ago
It is reasonable because issue form uses round.
source:tags/2.5.1/app/helpers/application_helper.rb#L1122
Updated by Toshi MARUYAMA over 10 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed in trunk r13137, thanks.
Updated by Jérôme BATAILLE over 10 years ago
Thanks a lot ! this is Smile 13'th patch integrated into the core.