Project

General

Profile

Actions

Defect #14846

closed

Calculation of the start date of following issues ignores the "non-working days" setting

Added by Jeffrey Lee about 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I found following problem when set delay for one issue.
If the start date of the following issue is Saturday, the system will move the start date to next Monday automatically.
However, if the start date of the following issue is others (across the weekend), the system will not take non-working days into consideration.
Please check the following example.
Is it a bug or my setting issue?

  • Non-working in my system is Saturday and Sunday.
  • Issue A: 2013/09/02(Mon.)~2013/09/03(Tue.)
  • Set issue B follows issue A with N-days delay
    • N=1, Issue B start date: 2013/09/05(Thu.) => Correct
    • N=3, Issue B start date: 2013/09/09(Mon.) => Correct
    • N=4, Issue B start date: 2013/09/09(Mon.) => Incorrect, SHOULD be 2013/09/10
    • N=6, Issue B start date: 2013/09/10(Tue.) => Incorrect, SHOULD be 2013/09/12

System information:

Environment:
  Redmine version                2.3.2.stable
  Ruby version                   1.9.3-p448 (2013-06-27) [x86_64-linux]
  Rails version                  3.2.13
  Environment                    production
  Database adapter               Mysql2
Redmine plugins:
  clipboard_image_paste          1.7
  redmine_projects_accordion     0.1.0
  redmine_tab                    0.4.0
  redmine_theme_changer          0.1.0
  redmine_watcher_groups         0.0.2git
  redmine_work_time              0.2.8
  timelog_timer                  2.0.0


Files

14846.patch (3.25 KB) 14846.patch Felix Schäfer, 2014-03-10 23:11
14846-r17212.patch (3.01 KB) 14846-r17212.patch patch for r17212 Go MAEDA, 2018-02-26 10:42

Related issues

Related to Redmine - Defect #29855: add_working_days returns wrong dateConfirmedGo MAEDA

Actions
Actions #1

Updated by Toshi MARUYAMA about 11 years ago

  • Category set to Issues
Actions #2

Updated by Felix Schäfer over 10 years ago

One of our (Planio) customers noticed this bug too. We can confirm that the calculation of the start date of following issues does not take the "non-working days" setting into account.

The attached patch solves this and adds a test for this behavior.

Actions #3

Updated by Etienne Massip over 10 years ago

  • Target version set to Candidate for next minor release
Actions #4

Updated by Go MAEDA over 6 years ago

I have updated the patch for the current trunk (r17212).

Setting target version to 4.0.0.

Actions #5

Updated by Go MAEDA over 6 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you for your contribution.

Actions #6

Updated by Go MAEDA over 6 years ago

  • Subject changed from Problem for setting issue B follows issue A with N-days delay to Calculation of the start date of following issues ignores the "non-working days" setting
Actions #7

Updated by Go MAEDA about 6 years ago

  • Related to Defect #29855: add_working_days returns wrong date added
Actions

Also available in: Atom PDF