Patch #15689: Make favicon themeable - Redmine

Patch #15689

Make favicon themeable

Added by Felix Schäfer over 7 years ago. Updated about 5 years ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

Jean-Philippe Lang

% Done:

0%

Category:

Themes

Target version:

Description

Plan.io had the case that we needed to be able to set the favicon according to the theme. We have developed a patch to be able to use a favicon from the favicon directory in the theme directory (if more than one is available the [].first will be used).

(Patch coming up as soon as I have an issue number)

15689-theme_favicon.patch (1.5 KB) Felix Schäfer, 2013-12-12 16:10

15689-theme_favicon.patch (3.34 KB) Felix Schäfer, 2013-12-14 12:31

Associated revisions

Revision 12646
Added by Jean-Philippe Lang over 7 years ago

Make favicon themeable (#15689).

Patch by Felix Schäfer modified by Jean-Philippe Lang.

History

#1 Updated by Felix Schäfer over 7 years ago

File 15689-theme_favicon.patch added
Status changed from New to Resolved

Here's the patch.

#2 Updated by Jan Niggemann (redmine.org team member) over 7 years ago

Tracker changed from Feature to Patch
Status changed from Resolved to New

#3 Updated by Jean-Philippe Lang over 7 years ago

Could you add a test for this? See source:/trunk/test/integration/lib/redmine/themes_test.rb

#4 Updated by Felix Schäfer over 7 years ago

File 15689-theme_favicon.patch added

Sure, see the attached updated patch.

#5 Updated by Jean-Philippe Lang over 7 years ago

Target version set to 2.5.0

#6 Updated by Jean-Philippe Lang over 7 years ago

Status changed from New to Closed
Assignee set to Jean-Philippe Lang

Patch committed in r12646 with slight changes:

ruby 1.8 compatibility syntax
use of #assert_select instead of #assert_tag

Thanks.

#7 Updated by Felix Schäfer over 7 years ago

Thanks!

Also available in: Atom PDF