Patch #15689: Make favicon themeable - Redmine

Actions

Patch #15689

closed

Make favicon themeable

Added by Felix Schäfer about 11 years ago. Updated almost 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Themes

Target version:

Start date:

Due date:

% Done:

0%

Estimated time:

Description

Plan.io had the case that we needed to be able to set the favicon according to the theme. We have developed a patch to be able to use a favicon from the favicon directory in the theme directory (if more than one is available the [].first will be used).

(Patch coming up as soon as I have an issue number)

Files

Download all files

15689-theme_favicon.patch (1.5 KB) 15689-theme_favicon.patch		Felix Schäfer, 2013-12-12 16:10
15689-theme_favicon.patch (3.34 KB) 15689-theme_favicon.patch		Felix Schäfer, 2013-12-14 12:31

Actions

#1

Updated by Felix Schäfer about 11 years ago

File 15689-theme_favicon.patch 15689-theme_favicon.patch added
Status changed from New to Resolved

Here's the patch.

Actions

#2

Updated by Jan Niggemann (redmine.org team member) about 11 years ago

Tracker changed from Feature to Patch
Status changed from Resolved to New

Actions

#3

Updated by Jean-Philippe Lang about 11 years ago

Could you add a test for this? See source:/trunk/test/integration/lib/redmine/themes_test.rb

Actions

#4

Updated by Felix Schäfer about 11 years ago

File 15689-theme_favicon.patch 15689-theme_favicon.patch added

Sure, see the attached updated patch.

Actions

#5

Updated by Jean-Philippe Lang almost 11 years ago

Target version set to 2.5.0

Actions

#6

Updated by Jean-Philippe Lang almost 11 years ago

Status changed from New to Closed
Assignee set to Jean-Philippe Lang

Patch committed in r12646 with slight changes:

ruby 1.8 compatibility syntax
use of #assert_select instead of #assert_tag

Thanks.

Actions

#7

Updated by Felix Schäfer almost 11 years ago

Thanks!

Actions

Also available in: Atom PDF